2022-09-22 20:49:25

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree

> + chosen {
> + stdout-path = "serial0:115200n8";
> + bootargs = "console=ttyS0,115200n8 earlyprintk";

bootargs is generally not liked. Since you have stdout-path do you
need console=ttyS0,115200n8? earlyprintk should not be needed now you
have something which boots.

> +&mdio {
> + status = "okay";
> +
> + ethphy: ethernet-phy {
> + reg = <8>;

Since you have a reg value, this should be ethernet-phy@9

Andrew


2022-09-22 21:33:01

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree

On Thursday 22 September 2022 22:45:47 Andrew Lunn wrote:
> > +&mdio {
> > + status = "okay";
> > +
> > + ethphy: ethernet-phy {
> > + reg = <8>;
>
> Since you have a reg value, this should be ethernet-phy@9

ethernet-phy@8 no?

2022-09-22 22:21:26

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree

On Thu, Sep 22, 2022 at 11:14:08PM +0200, Pali Roh?r wrote:
> On Thursday 22 September 2022 22:45:47 Andrew Lunn wrote:
> > > +&mdio {
> > > + status = "okay";
> > > +
> > > + ethphy: ethernet-phy {
> > > + reg = <8>;
> >
> > Since you have a reg value, this should be ethernet-phy@9
>
> ethernet-phy@8 no?

Yes, @8. Sorry.

Andrew