2022-09-23 16:20:54

by Krzysztof Kozlowski

Subject: [PATCH 07/11] arm64: dts: qcom: sdm8458: align node names with DT schema

New slimbus DT schema expect only SLIMbus bus nodes to be named
"slimbus". In case of Qualcomm SLIMbus NGD, the bus node is what was
called "ngd".

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 1213f78a8b7a..7b62efb180d5 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -3823,7 +3823,7 @@ qspi: spi@88df000 {
status = "disabled";
};

- slim: slim@171c0000 {
+ slim: slim-ngd@171c0000 {
compatible = "qcom,slim-ngd-v2.1.0";
reg = <0 0x171c0000 0 0x2c000>;
interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
@@ -3835,7 +3835,7 @@ slim: slim@171c0000 {
#address-cells = <1>;
#size-cells = <0>;

- ngd@1 {
+ slim@1 {
reg = <1>;
#address-cells = <2>;
#size-cells = <0>;
--
2.34.1

2022-09-25 19:56:12

by Steev Klimaszewski

Subject: Re: [PATCH 07/11] arm64: dts: qcom: sdm8458: align node names with DT schema

Hi Krztof

On 9/23/22 11:14 AM, Krzysztof Kozlowski wrote:
> New slimbus DT schema expect only SLIMbus bus nodes to be named
> "slimbus". In case of Qualcomm SLIMbus NGD, the bus node is what was
> called "ngd".
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 1213f78a8b7a..7b62efb180d5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -3823,7 +3823,7 @@ qspi: spi@88df000 {
> status = "disabled";
> };
>
> - slim: slim@171c0000 {
> + slim: slim-ngd@171c0000 {
> compatible = "qcom,slim-ngd-v2.1.0";
> reg = <0 0x171c0000 0 0x2c000>;
> interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> @@ -3835,7 +3835,7 @@ slim: slim@171c0000 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - ngd@1 {
> + slim@1 {
> reg = <1>;
> #address-cells = <2>;
> #size-cells = <0>;

Subject has a typo - sdm8458 -> sdm845

Tested on Lenovo Yoga C630

Tested-by: Steev Klimaszewski <[email protected]>

2022-09-26 07:45:58

by Krzysztof Kozlowski

Subject: Re: [PATCH 07/11] arm64: dts: qcom: sdm8458: align node names with DT schema

On 25/09/2022 20:58, Steev Klimaszewski wrote:
>> #address-cells = <2>;
>> #size-cells = <0>;
>
> Subject has a typo - sdm8458 -> sdm845

Indeed.

>
> Tested on Lenovo Yoga C630
>
> Tested-by: Steev Klimaszewski <[email protected]>

Thanks!

Best regards,
Krzysztof