2022-09-25 18:05:33

by Luca Weiss

Subject: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name

The name rgb-led is not allowed, multi-led is supposed to be used.

<snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml

Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +-
.../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
index 5a70683d9103..c1d97190ea71 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
@@ -178,7 +178,7 @@ &pm8941_lpg {

qcom,power-source = <1>;

- rgb-led {
+ multi-led {
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STATUS;

diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 85348562e861..94daa1a3240a 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -295,7 +295,7 @@ &pm8941_lpg {

qcom,power-source = <1>;

- rgb-led {
+ multi-led {
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STATUS;

--
2.37.3

2022-09-26 09:35:33

by Neil Armstrong

Subject: Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name

On 25/09/2022 19:56, Luca Weiss wrote:
> The name rgb-led is not allowed, multi-led is supposed to be used.
>
> <snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
> From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +-
> .../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index 5a70683d9103..c1d97190ea71 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -178,7 +178,7 @@ &pm8941_lpg {
>
> qcom,power-source = <1>;
>
> - rgb-led {
> + multi-led {
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_STATUS;
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 85348562e861..94daa1a3240a 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -295,7 +295,7 @@ &pm8941_lpg {
>
> qcom,power-source = <1>;
>
> - rgb-led {
> + multi-led {
> color = <LED_COLOR_ID_RGB>;
> function = LED_FUNCTION_STATUS;
>

Reviewed-by: Neil Armstrong <[email protected]>

2022-10-18 03:58:35

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name

On Sun, 25 Sep 2022 19:56:30 +0200, Luca Weiss wrote:
> The name rgb-led is not allowed, multi-led is supposed to be used.
>
> <snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
> From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name
commit: 5da0f6fedb18d447cbe6d8aa5be33291bce1e7ba

Best regards,
--
Bjorn Andersson <[email protected]>