2022-09-26 03:06:17

by Jinjie Ruan

[permalink] [raw]
Subject: [PATCH -next] drm/ast: make ast_modeset static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
was not declared. Should it be static?

Signed-off-by: ruanjinjie <[email protected]>
---
drivers/gpu/drm/ast/ast_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 760b27971557..b9392f31e629 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -39,7 +39,7 @@

#include "ast_drv.h"

-int ast_modeset = -1;
+static int ast_modeset = -1;

MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, ast_modeset, int, 0400);
--
2.25.1


2022-09-26 07:44:53

by Thomas Zimmermann

[permalink] [raw]
Subject: Re: [PATCH -next] drm/ast: make ast_modeset static

Hi

Am 26.09.22 um 04:32 schrieb ruanjinjie:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
> was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <[email protected]>

Thank you. Added to drm-misc-next.

Best regards
Thomas

> ---
> drivers/gpu/drm/ast/ast_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 760b27971557..b9392f31e629 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -39,7 +39,7 @@
>
> #include "ast_drv.h"
>
> -int ast_modeset = -1;
> +static int ast_modeset = -1;
>
> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, ast_modeset, int, 0400);

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachments:
OpenPGP_signature (855.00 B)
OpenPGP digital signature

2022-09-26 08:02:10

by Jinjie Ruan

[permalink] [raw]
Subject: Re: [PATCH -next] drm/ast: make ast_modeset static

Thank you very much!

On 2022/9/26 15:16, Thomas Zimmermann wrote:
> Hi
>
> Am 26.09.22 um 04:32 schrieb ruanjinjie:
>> The symbol is not used outside of the file, so mark it static.
>>
>> Fixes the following warning:
>>
>> drivers/gpu/drm/ast/ast_drv.c:42:5: warning: symbol 'ast_modeset'
>> was not declared. Should it be static?
>>
>> Signed-off-by: ruanjinjie <[email protected]>
>
> Thank you. Added to drm-misc-next.
>
> Best regards
> Thomas
>
>> ---
>>   drivers/gpu/drm/ast/ast_drv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_drv.c
>> b/drivers/gpu/drm/ast/ast_drv.c
>> index 760b27971557..b9392f31e629 100644
>> --- a/drivers/gpu/drm/ast/ast_drv.c
>> +++ b/drivers/gpu/drm/ast/ast_drv.c
>> @@ -39,7 +39,7 @@
>>     #include "ast_drv.h"
>>   -int ast_modeset = -1;
>> +static int ast_modeset = -1;
>>     MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>>   module_param_named(modeset, ast_modeset, int, 0400);
>