2022-09-26 09:39:48

by Jinjie Ruan

Subject: [PATCH -next] block/swim3: add __init annotation to module init func

Add missing __init annotation to module init func.

Signed-off-by: ruanjinjie <[email protected]>
---
drivers/block/swim3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index da811a7da03f..1f65d506fbc9 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
};


-int swim3_init(void)
+int __init swim3_init(void)
{
macio_register_driver(&swim3_driver);
return 0;
--
2.25.1

2022-09-26 19:04:42

by Christophe JAILLET

Subject: Re: [PATCH -next] block/swim3: add __init annotation to module init func

Le 26/09/2022 à 11:22, ruanjinjie a écrit :
> Add missing __init annotation to module init func.
>
> Signed-off-by: ruanjinjie <[email protected]>
> ---
> drivers/block/swim3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index da811a7da03f..1f65d506fbc9 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver =
> };
>
>
> -int swim3_init(void)
> +int __init swim3_init(void)
> {
> macio_register_driver(&swim3_driver);
> return 0;

Hi,

unrelated, but should there be a swim3_exit() to call
macio_register_driver(), as already done in some other drivers using
these functions?

CJ