Now that the driver makes use of `__clk_is_enabled()` in order to
know whether a `clk_disable_unprepare()` is needed or not on the
GCLK, a new dependency has been introduced: COMMON_CLK. If this
`CONFIG_COMMON_CLK` is not enabled, whatever config may have this
driver enabled without COMMON_CLK then an undefined reference to
`__clk_is_enabled()` will be issued by the linker.
Thus, make sure that, unless `CONFIG_COMMON_CLK` is enabled, this
driver is not compiled.
Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Sergiu Moga <[email protected]>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a18dd525e42b..1aec3cf002f7 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -127,6 +127,7 @@ config SERIAL_SB1250_DUART_CONSOLE
config SERIAL_ATMEL
bool "AT91 on-chip serial port support"
+ depends on COMMON_CLK
depends on ARCH_AT91 || COMPILE_TEST
select SERIAL_CORE
select SERIAL_MCTRL_GPIO if GPIOLIB
--
2.34.1
On 26/09/2022 at 16:32, Sergiu Moga wrote:
> Now that the driver makes use of `__clk_is_enabled()` in order to
> know whether a `clk_disable_unprepare()` is needed or not on the
> GCLK, a new dependency has been introduced: COMMON_CLK. If this
> `CONFIG_COMMON_CLK` is not enabled, whatever config may have this
> driver enabled without COMMON_CLK then an undefined reference to
> `__clk_is_enabled()` will be issued by the linker.
>
> Thus, make sure that, unless `CONFIG_COMMON_CLK` is enabled, this
> driver is not compiled.
>
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Sergiu Moga <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index a18dd525e42b..1aec3cf002f7 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -127,6 +127,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>
> config SERIAL_ATMEL
> bool "AT91 on-chip serial port support"
> + depends on COMMON_CLK
> depends on ARCH_AT91 || COMPILE_TEST
> select SERIAL_CORE
> select SERIAL_MCTRL_GPIO if GPIOLIB
--
Nicolas Ferre