This series removes hal/odm_RegConfig8188E.c and its header
odm_RegConfig8188E.h by making the functions defined in that file
static.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (3):
staging: r8188eu: make odm_ConfigMAC_8188E() static
staging: r8188eu: make odm_ConfigRF_RadioA_8188E() static
staging: r8188eu: remove hal/odm_RegConfig8188E.c
drivers/staging/r8188eu/Makefile | 1 -
.../staging/r8188eu/hal/HalHWImg8188E_BB.c | 50 +++++++++++
.../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 5 ++
.../staging/r8188eu/hal/HalHWImg8188E_RF.c | 30 +++++++
.../staging/r8188eu/hal/odm_RegConfig8188E.c | 89 -------------------
.../r8188eu/include/odm_RegConfig8188E.h | 21 -----
.../staging/r8188eu/include/rtl8188e_hal.h | 1 -
7 files changed, 85 insertions(+), 112 deletions(-)
delete mode 100644 drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
delete mode 100644 drivers/staging/r8188eu/include/odm_RegConfig8188E.h
--
2.37.3
The function odm_ConfigMAC_8188E() is only used in HalHWImg8188E_MAC.c.
Make it static.
Signed-off-by: Michael Straube <[email protected]>
---
drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c | 5 +++++
drivers/staging/r8188eu/hal/odm_RegConfig8188E.c | 5 -----
drivers/staging/r8188eu/include/odm_RegConfig8188E.h | 2 --
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c b/drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c
index 77b25885c63b..e615bc37c74f 100644
--- a/drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c
+++ b/drivers/staging/r8188eu/hal/HalHWImg8188E_MAC.c
@@ -126,6 +126,11 @@ static u32 array_MAC_REG_8188E[] = {
0x70B, 0x00000087,
};
+static void odm_ConfigMAC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u8 Data)
+{
+ rtw_write8(pDM_Odm->Adapter, Addr, Data);
+}
+
enum HAL_STATUS ODM_ReadAndConfig_MAC_REG_8188E(struct odm_dm_struct *dm_odm)
{
#define READ_NEXT_PAIR(v1, v2, i) do { i += 2; v1 = array[i]; v2 = array[i + 1]; } while (0)
diff --git a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
index 0fa17a99f9e9..e6e10a3c8d54 100644
--- a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
+++ b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
@@ -33,11 +33,6 @@ void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data
odm_ConfigRFReg_8188E(pDM_Odm, Addr, Data, Addr | maskforPhySet);
}
-void odm_ConfigMAC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u8 Data)
-{
- rtw_write8(pDM_Odm->Adapter, Addr, Data);
-}
-
void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask, u32 Data)
{
rtl8188e_PHY_SetBBReg(pDM_Odm->Adapter, Addr, Bitmask, Data);
diff --git a/drivers/staging/r8188eu/include/odm_RegConfig8188E.h b/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
index 683fa4a07956..9cecbf9532f5 100644
--- a/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
+++ b/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
@@ -7,8 +7,6 @@
void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm,
u32 Addr, u32 Data);
-void odm_ConfigMAC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u8 Data);
-
void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
u32 Bitmask, u32 Data);
--
2.37.3
The function odm_ConfigRF_RadioA_8188E() is only used in
HalHWImg8188E_RF.c. Make it static.
Signed-off-by: Michael Straube <[email protected]>
---
.../staging/r8188eu/hal/HalHWImg8188E_RF.c | 30 +++++++++++++++++++
.../staging/r8188eu/hal/odm_RegConfig8188E.c | 30 -------------------
.../r8188eu/include/odm_RegConfig8188E.h | 3 --
3 files changed, 30 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c b/drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c
index 08cbfce3808d..ea123817e3d5 100644
--- a/drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c
+++ b/drivers/staging/r8188eu/hal/HalHWImg8188E_RF.c
@@ -130,6 +130,36 @@ static u32 Array_RadioA_1T_8188E[] = {
0x000, 0x00033E60,
};
+static void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
+ u32 Data, u32 RegAddr)
+{
+ if (Addr == 0xffe) {
+ msleep(50);
+ } else if (Addr == 0xfd) {
+ mdelay(5);
+ } else if (Addr == 0xfc) {
+ mdelay(1);
+ } else if (Addr == 0xfb) {
+ udelay(50);
+ } else if (Addr == 0xfa) {
+ udelay(5);
+ } else if (Addr == 0xf9) {
+ udelay(1);
+ } else {
+ rtl8188e_PHY_SetRFReg(pDM_Odm->Adapter, RegAddr, bRFRegOffsetMask, Data);
+ /* Add 1us delay between BB/RF register setting. */
+ udelay(1);
+ }
+}
+
+static void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data)
+{
+ u32 content = 0x1000; /* RF_Content: radioa_txt */
+ u32 maskforPhySet = (u32)(content & 0xE000);
+
+ odm_ConfigRFReg_8188E(pDM_Odm, Addr, Data, Addr | maskforPhySet);
+}
+
enum HAL_STATUS ODM_ReadAndConfig_RadioA_1T_8188E(struct odm_dm_struct *pDM_Odm)
{
#define READ_NEXT_PAIR(v1, v2, i) do \
diff --git a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
index e6e10a3c8d54..963697574e9e 100644
--- a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
+++ b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
@@ -3,36 +3,6 @@
#include "../include/drv_types.h"
-static void odm_ConfigRFReg_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
- u32 Data, u32 RegAddr)
-{
- if (Addr == 0xffe) {
- msleep(50);
- } else if (Addr == 0xfd) {
- mdelay(5);
- } else if (Addr == 0xfc) {
- mdelay(1);
- } else if (Addr == 0xfb) {
- udelay(50);
- } else if (Addr == 0xfa) {
- udelay(5);
- } else if (Addr == 0xf9) {
- udelay(1);
- } else {
- rtl8188e_PHY_SetRFReg(pDM_Odm->Adapter, RegAddr, bRFRegOffsetMask, Data);
- /* Add 1us delay between BB/RF register setting. */
- udelay(1);
- }
-}
-
-void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data)
-{
- u32 content = 0x1000; /* RF_Content: radioa_txt */
- u32 maskforPhySet = (u32)(content & 0xE000);
-
- odm_ConfigRFReg_8188E(pDM_Odm, Addr, Data, Addr | maskforPhySet);
-}
-
void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask, u32 Data)
{
rtl8188e_PHY_SetBBReg(pDM_Odm->Adapter, Addr, Bitmask, Data);
diff --git a/drivers/staging/r8188eu/include/odm_RegConfig8188E.h b/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
index 9cecbf9532f5..ce8af50d13bb 100644
--- a/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
+++ b/drivers/staging/r8188eu/include/odm_RegConfig8188E.h
@@ -4,9 +4,6 @@
#ifndef __INC_ODM_REGCONFIG_H_8188E
#define __INC_ODM_REGCONFIG_H_8188E
-void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm,
- u32 Addr, u32 Data);
-
void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
u32 Bitmask, u32 Data);
--
2.37.3
On 9/26/22 19:32, Michael Straube wrote:
> This series removes hal/odm_RegConfig8188E.c and its header
> odm_RegConfig8188E.h by making the functions defined in that file
> static.
>
> Tested on x86_64 with Inter-Tech DMG-02.
>
> Michael Straube (3):
> staging: r8188eu: make odm_ConfigMAC_8188E() static
> staging: r8188eu: make odm_ConfigRF_RadioA_8188E() static
> staging: r8188eu: remove hal/odm_RegConfig8188E.c
>
> drivers/staging/r8188eu/Makefile | 1 -
> .../staging/r8188eu/hal/HalHWImg8188E_BB.c | 50 +++++++++++
> .../staging/r8188eu/hal/HalHWImg8188E_MAC.c | 5 ++
> .../staging/r8188eu/hal/HalHWImg8188E_RF.c | 30 +++++++
> .../staging/r8188eu/hal/odm_RegConfig8188E.c | 89 -------------------
> .../r8188eu/include/odm_RegConfig8188E.h | 21 -----
> .../staging/r8188eu/include/rtl8188e_hal.h | 1 -
> 7 files changed, 85 insertions(+), 112 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
> delete mode 100644 drivers/staging/r8188eu/include/odm_RegConfig8188E.h
>
Tested-by: Philipp Hortmann <[email protected]> # Edimax N150