2022-09-26 18:33:44

by Chukun Pan

Subject: [PATCH 1/3] arm64: dts: rockchip: Add regulator suffix to rock-3a

Add -regulator suffix to regulator names on Radxa ROCK3 Model A
board. This makes the naming more consistent.

Signed-off-by: Chukun Pan <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index fb87a168fe96..8adf672709e8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -60,7 +60,7 @@ simple-audio-card,codec {
};
};

- vcc12v_dcin: vcc12v-dcin {
+ vcc12v_dcin: vcc12v-dcin-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc12v_dcin";
regulator-always-on;
@@ -79,7 +79,7 @@ vcc3v3_pcie: vcc3v3-pcie-regulator {
vin-supply = <&vcc5v0_sys>;
};

- vcc3v3_sys: vcc3v3-sys {
+ vcc3v3_sys: vcc3v3-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
regulator-always-on;
@@ -89,7 +89,7 @@ vcc3v3_sys: vcc3v3-sys {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_sys: vcc5v0-sys {
+ vcc5v0_sys: vcc5v0-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_sys";
regulator-always-on;
@@ -99,7 +99,7 @@ vcc5v0_sys: vcc5v0-sys {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_usb: vcc5v0-usb {
+ vcc5v0_usb: vcc5v0-usb-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_usb";
regulator-always-on;
@@ -109,7 +109,7 @@ vcc5v0_usb: vcc5v0-usb {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_usb_host: vcc5v0-usb-host {
+ vcc5v0_usb_host: vcc5v0-usb-host-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
@@ -144,7 +144,7 @@ vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
vin-supply = <&vcc5v0_usb>;
};

- vcc_cam: vcc-cam {
+ vcc_cam: vcc-cam-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
@@ -160,7 +160,7 @@ regulator-state-mem {
};
};

- vcc_mipi: vcc-mipi {
+ vcc_mipi: vcc-mipi-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
--
2.25.1

2022-09-27 05:55:46

by Michael Riesch

Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add regulator suffix to rock-3a

Hi Chukun,

On 9/26/22 20:01, Chukun Pan wrote:
> Add -regulator suffix to regulator names on Radxa ROCK3 Model A
> board. This makes the naming more consistent.
>
> Signed-off-by: Chukun Pan <[email protected]>

Acked-by: Michael Riesch <[email protected]>

Thanks and best regards,
Michael

> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index fb87a168fe96..8adf672709e8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -60,7 +60,7 @@ simple-audio-card,codec {
> };
> };
>
> - vcc12v_dcin: vcc12v-dcin {
> + vcc12v_dcin: vcc12v-dcin-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc12v_dcin";
> regulator-always-on;
> @@ -79,7 +79,7 @@ vcc3v3_pcie: vcc3v3-pcie-regulator {
> vin-supply = <&vcc5v0_sys>;
> };
>
> - vcc3v3_sys: vcc3v3-sys {
> + vcc3v3_sys: vcc3v3-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3_sys";
> regulator-always-on;
> @@ -89,7 +89,7 @@ vcc3v3_sys: vcc3v3-sys {
> vin-supply = <&vcc12v_dcin>;
> };
>
> - vcc5v0_sys: vcc5v0-sys {
> + vcc5v0_sys: vcc5v0-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_sys";
> regulator-always-on;
> @@ -99,7 +99,7 @@ vcc5v0_sys: vcc5v0-sys {
> vin-supply = <&vcc12v_dcin>;
> };
>
> - vcc5v0_usb: vcc5v0-usb {
> + vcc5v0_usb: vcc5v0-usb-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_usb";
> regulator-always-on;
> @@ -109,7 +109,7 @@ vcc5v0_usb: vcc5v0-usb {
> vin-supply = <&vcc12v_dcin>;
> };
>
> - vcc5v0_usb_host: vcc5v0-usb-host {
> + vcc5v0_usb_host: vcc5v0-usb-host-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
> @@ -144,7 +144,7 @@ vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
> vin-supply = <&vcc5v0_usb>;
> };
>
> - vcc_cam: vcc-cam {
> + vcc_cam: vcc-cam-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
> @@ -160,7 +160,7 @@ regulator-state-mem {
> };
> };
>
> - vcc_mipi: vcc-mipi {
> + vcc_mipi: vcc-mipi-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;