2022-09-27 12:49:52

by Bert Vermeulen

Subject: [PATCH v2 1/3] dt-bindings: arm: airoha: Add documentation for Airoha SPI controller

Create documentation for accessing the Airoha EN7523 SPI controller.

Signed-off-by: Bert Vermeulen <[email protected]>
---
.../bindings/spi/airoha,en7523-spi.yaml | 45 +++++++++++++++++++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml

diff --git a/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
new file mode 100644
index 000000000000..8f4936512a99
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/airoha,en7523-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha EN7523 SPI controller
+
+maintainers:
+ - Bert Vermeulen <[email protected]>
+
+description: |
+ This binding describes the SPI controller on Airoha EN7523 SoCs.
+
+allOf:
+ - $ref: spi-controller.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: airoha,en7523-spi
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/en7523-clk.h>
+ spi0: spi@1fa10000 {
+ compatible = "airoha,en7523-spi";
+ reg = <0x1fa10000 0x10000>;
+ clocks = <&scu EN7523_CLK_SPI>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
--
2.25.1

2022-09-29 22:30:40

by Rob Herring

Subject: Re: [PATCH v2 1/3] dt-bindings: arm: airoha: Add documentation for Airoha SPI controller

On Tue, 27 Sep 2022 13:32:27 +0200, Bert Vermeulen wrote:
> Create documentation for accessing the Airoha EN7523 SPI controller.
>
> Signed-off-by: Bert Vermeulen <[email protected]>
> ---
> .../bindings/spi/airoha,en7523-spi.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2022-09-30 11:15:42

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] dt-bindings: arm: airoha: Add documentation for Airoha SPI controller

On 27/09/2022 13:32, Bert Vermeulen wrote:
> Create documentation for accessing the Airoha EN7523 SPI controller.
>
> Signed-off-by: Bert Vermeulen <[email protected]>

Use subject prefixes matching the subsystem (git log --oneline -- ...).

> ---
> .../bindings/spi/airoha,en7523-spi.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
> new file mode 100644
> index 000000000000..8f4936512a99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/airoha,en7523-spi.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/airoha,en7523-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN7523 SPI controller
> +
> +maintainers:
> + - Bert Vermeulen <[email protected]>
> +
> +description: |
> + This binding describes the SPI controller on Airoha EN7523 SoCs.
> +
> +allOf:
> + - $ref: spi-controller.yaml#
> +
> +properties:
> + compatible:
> + items:

Drop "items:" and leading hyphen from line below.

> + - const: airoha,en7523-spi


Best regards,
Krzysztof