2022-09-28 09:48:47

by Xi Ruoyao

Subject: [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs

ZHITAI TiPro5000 SSDs has the same APST sleep problem as its cousin,
TiPro7000. The quirk for TiPro7000 has been added in
commit 6b961bce50e4 ("nvme-pci: avoid the deepest sleep state on
ZHITAI TiPro7000 SSDs"), use the same quirk for TiPro5000.

The ASPT data from "nvme id-ctrl /dev/nvme1":

vid : 0x1e49
ssvid : 0x1e49
sn : ZTA21T0KA2227304LM
mn : ZHITAI TiPlus5000 1TB
fr : ZTA09139
[...]
ps 0 : mp:6.50W operational enlat:0 exlat:0 rrt:0 rrl:0
rwt:0 rwl:0 idle_power:- active_power:-
ps 1 : mp:5.80W operational enlat:0 exlat:0 rrt:1 rrl:1
rwt:1 rwl:1 idle_power:- active_power:-
ps 2 : mp:3.60W operational enlat:0 exlat:0 rrt:2 rrl:2
rwt:2 rwl:2 idle_power:- active_power:-
ps 3 : mp:0.0500W non-operational enlat:5000 exlat:10000 rrt:3 rrl:3
rwt:3 rwl:3 idle_power:- active_power:-
ps 4 : mp:0.0025W non-operational enlat:8000 exlat:45000 rrt:4 rrl:4
rwt:4 rwl:4 idle_power:- active_power:-

Reported-and-tested-by: Chang Feng <[email protected]>
Signed-off-by: Xi Ruoyao <[email protected]>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 98864b853eef..65481d1975cc 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3513,6 +3513,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1dbe, 0x5236), /* ADATA XPG GAMMIX S70 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1e49, 0x0021), /* ZHITAI TiPro5000 NVMe SSD */
+ .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0x1e49, 0x0041), /* ZHITAI TiPro7000 NVMe SSD */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0xc0a9, 0x540a), /* Crucial P2 */
--
2.37.3

2022-10-05 04:52:00

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs

On 9/28/22 02:39, Xi Ruoyao wrote:
> ZHITAI TiPro5000 SSDs has the same APST sleep problem as its cousin,
> TiPro7000. The quirk for TiPro7000 has been added in
> commit 6b961bce50e4 ("nvme-pci: avoid the deepest sleep state on
> ZHITAI TiPro7000 SSDs"), use the same quirk for TiPro5000.
>
> The ASPT data from "nvme id-ctrl /dev/nvme1":
>
> vid : 0x1e49
> ssvid : 0x1e49
> sn : ZTA21T0KA2227304LM
> mn : ZHITAI TiPlus5000 1TB
> fr : ZTA09139
> [...]
> ps 0 : mp:6.50W operational enlat:0 exlat:0 rrt:0 rrl:0
> rwt:0 rwl:0 idle_power:- active_power:-
> ps 1 : mp:5.80W operational enlat:0 exlat:0 rrt:1 rrl:1
> rwt:1 rwl:1 idle_power:- active_power:-
> ps 2 : mp:3.60W operational enlat:0 exlat:0 rrt:2 rrl:2
> rwt:2 rwl:2 idle_power:- active_power:-
> ps 3 : mp:0.0500W non-operational enlat:5000 exlat:10000 rrt:3 rrl:3
> rwt:3 rwl:3 idle_power:- active_power:-
> ps 4 : mp:0.0025W non-operational enlat:8000 exlat:45000 rrt:4 rrl:4
> rwt:4 rwl:4 idle_power:- active_power:-
>
> Reported-and-tested-by: Chang Feng <[email protected]>
> Signed-off-by: Xi Ruoyao <[email protected]>


Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck

2022-10-10 08:33:42

by Christoph Hellwig

Subject: Re: [PATCH] nvme-pci: avoid the deepest sleep state on ZHITAI TiPro5000 SSDs

Thanks,

applied to nvme-6.1.