This series adds initial support for the PM6125 PMIC, and its power key
handling and thermal monitoring capabilities are configured for Sony's
PDX201 (Xperia 10II).
One patch for pm660 is included to fix a node address mismatch with its
reg field.
Changes since v3:
- Rebased on next-20220923 to fix (diff-context) conflicts with:
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t
Changes since v2:
- Rebased on v6.0-rc6 to drop dependent DT patches;
- Dropped iio patch which has already been picked into Jonathan's tree;
- Added qcom,pm6125 compatible in new yaml-ified SPMI-PMIC dt-bindings.
v2: https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u
Changes since v1:
- Dropped both pinctrl patches that have already been applied;
- Add -us suffix to qcom,hw-settle-time properties on ADC TM5 nodes
(this suffix is not present on regular ADC5/VADC nodes);
- Add -state suffix to pm6125_gpio pinctrl nodes;
- Use PMIC_GPIO_FUNC_NORMAL instead of the string-literal "normal";
- Removed #address-cells and #size-cells from empty pmic@1 node;
- Removed ADC5_AMUX_THM3 / ADC5_GPIO2_100K_PU channels from the ADC5
patch, these are unused on my board and hence untested.
v1: https://lore.kernel.org/phone-devel/[email protected]/T/#u
Marijn Suijten (5):
dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible
arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name
arm64: dts: qcom: Add PM6125 PMIC
arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON
arm64: dts: qcom: sm6125-seine: Configure additional trinket
thermistors
.../bindings/mfd/qcom,spmi-pmic.yaml | 1 +
arch/arm64/boot/dts/qcom/pm6125.dtsi | 154 +++++++++++++++++
arch/arm64/boot/dts/qcom/pm660.dtsi | 2 +-
.../qcom/sm6125-sony-xperia-seine-pdx201.dts | 162 +++++++++++++++++-
4 files changed, 317 insertions(+), 2 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/pm6125.dtsi
--
2.37.3
Document support for the pm6125, typically paired with the sm6125 SoC.
Signed-off-by: Marijn Suijten <[email protected]>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 6a3e3ede1ede..a5edab6f2e40 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -33,6 +33,7 @@ properties:
compatible:
items:
- enum:
+ - qcom,pm6125
- qcom,pm6150
- qcom,pm6150l
- qcom,pm6350
--
2.37.3
On 28/09/2022 10:10, Marijn Suijten wrote:
> On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote:
>> On 26/09/2022 21:01, Marijn Suijten wrote:
>>> Document support for the pm6125, typically paired with the sm6125 SoC.
>>>
>>> Signed-off-by: Marijn Suijten <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
>>
>>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Thanks, I thought of it this morning while browsing lore, but only got
> to a screen just now so you beat me to it by ~30 minutes.
>
> No need to lecture me on the rules, but I can't promise this won't
> happen again.
This is a automated message, don't get it too personal. A lot of people
are not aware they have to do it, so I just one, same reply. I don't
know whether you are aware of the process and just forgot to include it.
If that's the case, just ignore the message.
Best regards,
Krzysztof
On 2022-09-28 10:14:05, Krzysztof Kozlowski wrote:
> On 28/09/2022 10:10, Marijn Suijten wrote:
> > On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote:
> >> On 26/09/2022 21:01, Marijn Suijten wrote:
> >>> Document support for the pm6125, typically paired with the sm6125 SoC.
> >>>
> >>> Signed-off-by: Marijn Suijten <[email protected]>
> >>> ---
> >>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>
> >>
> >> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >> there's no need to repost patches *only* to add the tags. The upstream
> >> maintainer will do that for acks received on the version they apply.
> >>
> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> >>
> >>
> >> Acked-by: Krzysztof Kozlowski <[email protected]>
> >
> > https://lore.kernel.org/linux-arm-msm/[email protected]/
> >
> > Thanks, I thought of it this morning while browsing lore, but only got
> > to a screen just now so you beat me to it by ~30 minutes.
> >
> > No need to lecture me on the rules, but I can't promise this won't
> > happen again.
>
>
> This is a automated message, don't get it too personal. A lot of people
> are not aware they have to do it, so I just one, same reply. I don't
> know whether you are aware of the process and just forgot to include it.
> If that's the case, just ignore the message.
That's useful, what software are you using for this? Perhaps I can run
it as well, both to preempt myself and others.
(Side-note: I should get accustomed to `b4 shazam` to automatically pick
this up from the list, instead of rebasing / re-applying local patches)
- Marijn
On 26/09/2022 21:01, Marijn Suijten wrote:
> Document support for the pm6125, typically paired with the sm6125 SoC.
>
> Signed-off-by: Marijn Suijten <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 2022-09-28 09:35:40, Krzysztof Kozlowski wrote:
> On 26/09/2022 21:01, Marijn Suijten wrote:
> > Document support for the pm6125, typically paired with the sm6125 SoC.
> >
> > Signed-off-by: Marijn Suijten <[email protected]>
> > ---
> > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
https://lore.kernel.org/linux-arm-msm/[email protected]/
Thanks, I thought of it this morning while browsing lore, but only got
to a screen just now so you beat me to it by ~30 minutes.
No need to lecture me on the rules, but I can't promise this won't
happen again.
- Marijn
On 28/09/2022 10:23, Marijn Suijten wrote:
>>
>>
>> This is a automated message, don't get it too personal. A lot of people
>> are not aware they have to do it, so I just one, same reply. I don't
>> know whether you are aware of the process and just forgot to include it.
>> If that's the case, just ignore the message.
>
> That's useful, what software are you using for this? Perhaps I can run
> it as well, both to preempt myself and others.
https://gitlab.com/robherring/pw-utils/-/blob/master/mail-add-acks-reply
https://gitlab.com/robherring/pw-utils/-/blob/master/pw-review#L97
> (Side-note: I should get accustomed to `b4 shazam` to automatically pick
> this up from the list, instead of rebasing / re-applying local patches)
Would be nice if b4 could update patches in current branch adding the
tags... but git reset --hard && b4 shazam should work as well.
Best regards,
Krzysztof
On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote:
> > (Side-note: I should get accustomed to `b4 shazam` to automatically pick
> > this up from the list, instead of rebasing / re-applying local patches)
>
> Would be nice if b4 could update patches in current branch adding the
> tags... but git reset --hard && b4 shazam should work as well.
FYI, it can do just that using "b4 trailers -uF [msgid]". See:
https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html
-K
On 28/09/2022 17:44, Konstantin Ryabitsev wrote:
> On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote:
>>> (Side-note: I should get accustomed to `b4 shazam` to automatically pick
>>> this up from the list, instead of rebasing / re-applying local patches)
>>
>> Would be nice if b4 could update patches in current branch adding the
>> tags... but git reset --hard && b4 shazam should work as well.
>
> FYI, it can do just that using "b4 trailers -uF [msgid]". See:
> https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html
Wow, that's cool! Thanks!
Best regards,
Krzysztof
On 2022-09-28 11:44:37, Konstantin Ryabitsev wrote:
> On Wed, Sep 28, 2022 at 10:30:00AM +0200, Krzysztof Kozlowski wrote:
> > > (Side-note: I should get accustomed to `b4 shazam` to automatically pick
> > > this up from the list, instead of rebasing / re-applying local patches)
> >
> > Would be nice if b4 could update patches in current branch adding the
> > tags... but git reset --hard && b4 shazam should work as well.
>
> FYI, it can do just that using "b4 trailers -uF [msgid]". See:
> https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html
That's super cool and will save a lot of time. I'll also have to get
accustomed to `b4 prep` and `b4 send`, though typically prefer to look
at the `diff` between two `format-patch` revisions to make sure the
changelog is complete and no erratic changes made it in.
- Marijn
On Fri, Sep 30, 2022 at 02:31:18PM +0200, Marijn Suijten wrote:
> > FYI, it can do just that using "b4 trailers -uF [msgid]". See:
> > https://b4.docs.kernel.org/en/stable-0.10.y/contributor/trailers.html
>
> That's super cool and will save a lot of time. I'll also have to get
> accustomed to `b4 prep` and `b4 send`, though typically prefer to look
> at the `diff` between two `format-patch` revisions to make sure the
> changelog is complete and no erratic changes made it in.
(Dropping most people from CCs and adding the tools list.)
Hmm... Yes, we can do this, since we keep previously sent revisions tagged in
the tree. Something like:
b4 prep --compare v3
to show you a range-diff between v3 and the current revision.
-K
On Mon, 26 Sep 2022 21:01:43 +0200, Marijn Suijten wrote:
> This series adds initial support for the PM6125 PMIC, and its power key
> handling and thermal monitoring capabilities are configured for Sony's
> PDX201 (Xperia 10II).
>
> One patch for pm660 is included to fix a node address mismatch with its
> reg field.
>
> [...]
Applied, thanks!
[1/5] dt-bindings: mfd: qcom-spmi-pmic: Add pm6125 compatible
commit: 3da503c26ec572628802b4ffbe738a5d373cd3f6
[2/5] arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name
commit: 02549ba5de0a09a27616496c3512db5af4ad7862
[3/5] arm64: dts: qcom: Add PM6125 PMIC
commit: 7c969c6e216654cab8b124383dd99a276049994d
[4/5] arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON
commit: 7401035f2ef8841d0db9724507b45841d16894b6
[5/5] arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors
commit: 4ba146dd8897353e4e18a12c7866127f85c251e7
Best regards,
--
Bjorn Andersson <[email protected]>