2022-09-28 16:16:55

by Matthias Brugger

[permalink] [raw]
Subject: [PATCH 2/8] soc: mediatek: mtk-svs: improve readability of platform_probe

From: Matthias Brugger <[email protected]>

If a compatible misses a match data entry, then something is wrong in
the development phase, we don't need to check for that at runtime.

Signed-off-by: Matthias Brugger <[email protected]>
---

drivers/soc/mediatek/mtk-svs.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index fd0f636e8644..52bb4f8bbe6d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2332,10 +2332,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev)
int ret;

svsp_data = of_device_get_match_data(&pdev->dev);
- if (!svsp_data) {
- dev_err(&pdev->dev, "no svs platform data?\n");
- return ERR_PTR(-EPERM);
- }

svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL);
if (!svsp)
--
2.37.3


Subject: Re: [PATCH 2/8] soc: mediatek: mtk-svs: improve readability of platform_probe

Il 28/09/22 17:55, [email protected] ha scritto:
> From: Matthias Brugger <[email protected]>
>
> If a compatible misses a match data entry, then something is wrong in
> the development phase, we don't need to check for that at runtime.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> ---
>
> drivers/soc/mediatek/mtk-svs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index fd0f636e8644..52bb4f8bbe6d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2332,10 +2332,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev)
> int ret;
>
> svsp_data = of_device_get_match_data(&pdev->dev);

Changing that to device_get_match_data() (so, dropping of_) would be a plus
to this cleanup, perhaps...

In any case:
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

> - if (!svsp_data) {
> - dev_err(&pdev->dev, "no svs platform data?\n");
> - return ERR_PTR(-EPERM);
> - }
>
> svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL);
> if (!svsp)