2022-09-29 05:42:16

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v5 0/5] remoteproc: qcom: Add support for pronto-v3

This patch series adds support for the pronto-v3 remoteproc found on the
MSM8953 platform. It also converts the documentation for wcnss to YAML.

Changes since v4:
* Addressed comments to YAML conversion patch
* Added patch to fix docs for MSM8974

Sireesh Kodali (4):
dt-bindings: remoteproc: qcom: Convert wcnss documentation to YAML
dt-bindings: remoteproc: qcom: wcnss: Add qcom,pronto compatible
dt-bindings: remoteproc: qcom: wcnss: Add compatible for pronto v3
dt-bindings: remoteproc: wcnss-pil: Make supplies optionally required

Vladimir Lypak (1):
remoteproc: qcom: qcom_wcnss: Add support for pronto-v3

.../bindings/remoteproc/qcom,wcnss-pil.txt | 177 -----------
.../bindings/remoteproc/qcom,wcnss-pil.yaml | 294 ++++++++++++++++++
drivers/remoteproc/qcom_wcnss.c | 13 +
3 files changed, 307 insertions(+), 177 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt
create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml

--
2.37.3


2022-09-29 05:43:18

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v5 3/5] dt-bindings: remoteproc: qcom: wcnss: Add qcom,pronto compatible

This is not a fallback compatible, it must be present in addition to
"qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This
is the reason for documenting it in a separate commit.

This compatible is used in the wcn36xx driver to determine which
register must be accessed. However it isn't immediately clear why the
wcn36xx driver relies on this extra compatible string rather than just
looking for "qcom,pronto-v*".

Signed-off-by: Sireesh Kodali <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/remoteproc/qcom,wcnss-pil.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
index c22a6090220f..0eb2617e3482 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
@@ -15,10 +15,15 @@ description:

properties:
compatible:
- enum:
- - qcom,riva-pil
- - qcom,pronto-v1-pil
- - qcom,pronto-v2-pil
+ description:
+ Append "qcom,pronto" if the device is actually pronto, and not riva
+ oneOf:
+ - items:
+ - enum:
+ - qcom,pronto-v1-pil
+ - qcom,pronto-v2-pil
+ - const: qcom,pronto
+ - const: qcom,riva-pil

reg:
maxItems: 3
@@ -200,7 +205,7 @@ examples:
#include <dt-bindings/clock/qcom,rpmcc.h>
#include <dt-bindings/power/qcom-rpmpd.h>
pronto@a21b000 {
- compatible = "qcom,pronto-v2-pil";
+ compatible = "qcom,pronto-v2-pil", "qcom,pronto";
reg = <0x0a204000 0x2000>, <0x0a202000 0x1000>, <0x0a21b000 0x3000>;
reg-names = "ccu", "dxe", "pmu";

--
2.37.3

2022-09-29 05:43:21

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v5 5/5] dt-bindings: remoteproc: wcnss-pil: Make supplies optionally required

On MSM8974, power domains are not yet supported. The platform uses
regulators. This patch marks either the power-domains or *-supply as
required (instead of always requiring the power domains).

Signed-off-by: Sireesh Kodali <[email protected]>
---
.../devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
index 2ba2b6cf11fb..45eb42bd3c2c 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml
@@ -196,9 +196,13 @@ allOf:
deprecated: true
description: Deprecated for qcom,pronto-v1/2-pil

- required:
- - power-domains
- - power-domain-names
+ oneOf:
+ - required:
+ - power-domains
+ - power-domain-names
+ - required:
+ - vddmx-supply
+ - vddcx-supply

- if:
properties:
--
2.37.3

2022-09-29 09:26:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v5 5/5] dt-bindings: remoteproc: wcnss-pil: Make supplies optionally required

On 29/09/2022 07:02, Sireesh Kodali wrote:
> On MSM8974, power domains are not yet supported. The platform uses
> regulators. This patch marks either the power-domains or *-supply as
> required (instead of always requiring the power domains).
>
> Signed-off-by: Sireesh Kodali <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof