This series introduces the Qualcom sa8540p-ride automotive development
board, also called as Qdrive-3 board.
Changes in v4:
- Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board.
- Removed usb_1 related nodes, as usb1 doesn't have any port connected on
Qdrive3 board.
- Added Reported-by tag for Shazad(for ufs and usb_1 node removals)
Parikshit Pareek (3):
dt-bindings: arm: qcom: Document additional sa8540p device
arm64: dts: qcom: sa8295p: move common nodes to dtsi
arm64: dts: qcom: introduce sa8540p-ride dts
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 15 +
.../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
5 files changed, 31 insertions(+), 378 deletions(-)
rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
--
2.17.1
Create new dts file specific for Qdrive board based on sa8540p chipset.
Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
Qdrive board.
This is quite similar to sa8295 ADP development board. Main differences
are related to connectors, and interface cards, like USB external ports,
ethernet-switch, and PCIe switch etc.
Signed-off-by: Parikshit Pareek <[email protected]>
Reported-by: Shazad Hussain <[email protected]>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 31 +++++++++++++++++++
2 files changed, 32 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 68a172c4c748..e30d2a958937 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -54,6 +54,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sa8540p-adp-ride.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
new file mode 100644
index 000000000000..bd79866b80e1
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022, Linaro Limited
+ * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sa8540p-adp.dtsi"
+
+/ {
+ model = "Qualcomm SA8540 ADP";
+ compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
+};
+
+&ufs_card_hc {
+ status = "disabled";
+};
+
+&usb_1 {
+ status = "disabled";
+};
+
+&usb_1_hsphy {
+ status = "disabled";
+};
+
+&usb_1_qmpphy {
+ status = "disabled";
+};
--
2.17.1
Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.
Signed-off-by: Parikshit Pareek <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 3ab1ff6991bf..c6b802522183 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -675,6 +675,7 @@ properties:
- items:
- enum:
- qcom,sa8295p-adp
+ - qcom,sa8540p-adp-ride
- const: qcom,sa8540p
- items:
--
2.17.1
On 20/09/2022 14:08, Parikshit Pareek wrote:
> Create new dts file specific for Qdrive board based on sa8540p chipset.
> Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> Qdrive board.
>
> This is quite similar to sa8295 ADP development board. Main differences
> are related to connectors, and interface cards, like USB external ports,
> ethernet-switch, and PCIe switch etc.
>
> Signed-off-by: Parikshit Pareek <[email protected]>
> Reported-by: Shazad Hussain <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Tue, Sep 20, 2022 at 05:37:59PM +0530, Parikshit Pareek wrote:
> This series introduces the Qualcom sa8540p-ride automotive development
> board, also called as Qdrive-3 board.
>
> Changes in v4:
> - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board.
> - Removed usb_1 related nodes, as usb1 doesn't have any port connected on
> Qdrive3 board.
Please include the full change log here (also for earlier versions).
Also, please try to remember to CC people who have commented on earlier
versions of the series when resending.
> - Added Reported-by tag for Shazad(for ufs and usb_1 node removals)
This is generally not how we use Reported-by tags (even if the kbuild
robot sometimes gets credit for finding things during review this way).
You can give credit to reviewers by for example putting their name in
parentheses after the corresponding changelog entry (or just spelling
out who suggested the change).
> Parikshit Pareek (3):
> dt-bindings: arm: qcom: Document additional sa8540p device
> arm64: dts: qcom: sa8295p: move common nodes to dtsi
> arm64: dts: qcom: introduce sa8540p-ride dts
>
> .../devicetree/bindings/arm/qcom.yaml | 1 +
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
> arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 15 +
> .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
> 5 files changed, 31 insertions(+), 378 deletions(-)
> rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
> create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
Johan
On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote:
> Create new dts file specific for Qdrive board based on sa8540p chipset.
> Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> Qdrive board.
>
> This is quite similar to sa8295 ADP development board. Main differences
> are related to connectors, and interface cards, like USB external ports,
> ethernet-switch, and PCIe switch etc.
>
> Signed-off-by: Parikshit Pareek <[email protected]>
> Reported-by: Shazad Hussain <[email protected]>
> ---
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> new file mode 100644
> index 000000000000..bd79866b80e1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2022, Linaro Limited
> + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "sa8540p-adp.dtsi"
> +
> +/ {
> + model = "Qualcomm SA8540 ADP";
> + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
> +};
> +
> +&ufs_card_hc {
> + status = "disabled";
> +};
What about the UFS phy, etc?
This opt-out scheme seems quite fragile.
> +&usb_1 {
> + status = "disabled";
> +};
> +
> +&usb_1_hsphy {
> + status = "disabled";
> +};
> +
> +&usb_1_qmpphy {
> + status = "disabled";
> +};
Johan
On Wed, Sep 21, 2022 at 08:51:32AM +0200, Johan Hovold wrote:
> On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote:
> > Create new dts file specific for Qdrive board based on sa8540p chipset.
> > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> > Qdrive board.
> >
> > This is quite similar to sa8295 ADP development board. Main differences
> > are related to connectors, and interface cards, like USB external ports,
> > ethernet-switch, and PCIe switch etc.
> >
> > Signed-off-by: Parikshit Pareek <[email protected]>
> > Reported-by: Shazad Hussain <[email protected]>
> > ---
>
> > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > new file mode 100644
> > index 000000000000..bd79866b80e1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > @@ -0,0 +1,31 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2022, Linaro Limited
> > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sa8540p-adp.dtsi"
> > +
> > +/ {
> > + model = "Qualcomm SA8540 ADP";
> > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
> > +};
> > +
> > +&ufs_card_hc {
> > + status = "disabled";
> > +};
>
> What about the UFS phy, etc?
Really missed that. Will add phy nodes too.
>
> This opt-out scheme seems quite fragile.
>
> > +&usb_1 {
> > + status = "disabled";
> > +};
> > +
> > +&usb_1_hsphy {
> > + status = "disabled";
> > +};
> > +
> > +&usb_1_qmpphy {
> > + status = "disabled";
> > +};
>
> Johan
Regards,
Parikshit Pareek