2022-09-29 10:47:40

by Hongbin Wang

[permalink] [raw]
Subject: [PATCH] seg6: Delete invalid code

void function return statements are not generally useful

Signed-off-by: Hongbin Wang <[email protected]>
---
net/ipv6/seg6_local.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
index b7de5e46fdd8..a799ac83df3a 100644
--- a/net/ipv6/seg6_local.c
+++ b/net/ipv6/seg6_local.c
@@ -1830,8 +1830,6 @@ static void seg6_local_destroy_state(struct lwtunnel_state *lwt)
seg6_local_lwtunnel_destroy_state(slwt);

destroy_attrs(slwt);
-
- return;
}

static int seg6_local_fill_encap(struct sk_buff *skb,
--
2.25.1


2022-09-30 02:04:40

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] seg6: Delete invalid code

On Thu, 29 Sep 2022 05:56:49 -0400 Hongbin Wang wrote:
> void function return statements are not generally useful

I don't think this is worth applying, sorry.