2022-10-01 03:25:03

by Melody Olvera

[permalink] [raw]
Subject: [PATCH 0/2] Add dma gpi support for QDU1000/QRU1000 SoCs

This series adds the dt bindings and driver support for dma gpi driver
on the QDU1000 and QRU1000 SoCs.

The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf

Melody Olvera (2):
dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and
QRU1000
dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
drivers/dma/qcom/gpi.c | 2 ++
2 files changed, 4 insertions(+)


base-commit: 987a926c1d8a40e4256953b04771fbdb63bc7938
--
2.37.3


2022-10-01 03:27:36

by Melody Olvera

[permalink] [raw]
Subject: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.

Signed-off-by: Melody Olvera <[email protected]>
---
drivers/dma/qcom/gpi.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8f0c9c4e2efd..94f92317979c 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
{ .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
{ .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
{ .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
+ { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
+ { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
{ },
};
MODULE_DEVICE_TABLE(of, gpi_of_match);
--
2.37.3

2022-10-01 03:28:37

by Melody Olvera

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

Add compatible documentation for Qualcomm QDU1000 and QRU1000 SoCs.

Signed-off-by: Melody Olvera <[email protected]>
---
Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index 7d2fc4eb5530..e37cee079c78 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -25,6 +25,8 @@ properties:
- qcom,sm8250-gpi-dma
- qcom,sm8350-gpi-dma
- qcom,sm8450-gpi-dma
+ - qcom,qdu1000-gpi-dma
+ - qcom,qru1000-gpi-dma

reg:
maxItems: 1
--
2.37.3

2022-10-01 07:18:25

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

On Sat, 1 Oct 2022 at 06:08, Melody Olvera <[email protected]> wrote:
>
> Add compatible documentation for Qualcomm QDU1000 and QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <[email protected]>
> ---
> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index 7d2fc4eb5530..e37cee079c78 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -25,6 +25,8 @@ properties:
> - qcom,sm8250-gpi-dma
> - qcom,sm8350-gpi-dma
> - qcom,sm8450-gpi-dma
> + - qcom,qdu1000-gpi-dma
> + - qcom,qru1000-gpi-dma

You know my comment, qdu/qru comes before sm/sc

>
> reg:
> maxItems: 1
> --
> 2.37.3
>


--
With best wishes
Dmitry

2022-10-01 07:20:32

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

On Sat, 1 Oct 2022 at 06:08, Melody Olvera <[email protected]> wrote:
>
> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <[email protected]>
> ---
> drivers/dma/qcom/gpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 8f0c9c4e2efd..94f92317979c 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
> { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
> { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
> { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
> + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
> + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },

As usual

> { },
> };
> MODULE_DEVICE_TABLE(of, gpi_of_match);
> --
> 2.37.3
>


--
With best wishes
Dmitry

2022-10-01 09:51:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

On 01/10/2022 09:14, Dmitry Baryshkov wrote:
> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <[email protected]> wrote:
>>
>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>
>> Signed-off-by: Melody Olvera <[email protected]>
>> ---
>> drivers/dma/qcom/gpi.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>> index 8f0c9c4e2efd..94f92317979c 100644
>> --- a/drivers/dma/qcom/gpi.c
>> +++ b/drivers/dma/qcom/gpi.c
>> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
>> { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>> { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
>> { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
>> + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>> + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>
> As usual

I would say - drop entire patch and rebase patchset on:

https://patchwork.kernel.org/project/linux-arm-msm/list/?series=680815&state=*

Best regards,
Krzysztof

2022-10-04 20:20:56

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000



On 10/1/2022 2:13 AM, Dmitry Baryshkov wrote:
> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <[email protected]> wrote:
>> Add compatible documentation for Qualcomm QDU1000 and QRU1000 SoCs.
>>
>> Signed-off-by: Melody Olvera <[email protected]>
>> ---
>> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> index 7d2fc4eb5530..e37cee079c78 100644
>> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> @@ -25,6 +25,8 @@ properties:
>> - qcom,sm8250-gpi-dma
>> - qcom,sm8350-gpi-dma
>> - qcom,sm8450-gpi-dma
>> + - qcom,qdu1000-gpi-dma
>> + - qcom,qru1000-gpi-dma
> You know my comment, qdu/qru comes before sm/sc
Got it.
>> reg:
>> maxItems: 1
>> --
>> 2.37.3
>>
Thanks,
Melody

2022-10-04 20:50:01

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000



On 10/1/2022 4:30 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 09:14, Dmitry Baryshkov wrote:
>> On Sat, 1 Oct 2022 at 06:08, Melody Olvera <[email protected]> wrote:
>>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>>
>>> Signed-off-by: Melody Olvera <[email protected]>
>>> ---
>>> drivers/dma/qcom/gpi.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>>> index 8f0c9c4e2efd..94f92317979c 100644
>>> --- a/drivers/dma/qcom/gpi.c
>>> +++ b/drivers/dma/qcom/gpi.c
>>> @@ -2292,6 +2292,8 @@ static const struct of_device_id gpi_of_match[] = {
>>> { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>>> { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
>>> { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 },
>>> + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>>> + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>> As usual
Will address ordering.
> I would say - drop entire patch and rebase patchset on:
>
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=680815&state=*
Sure thing; will rebase.
>
> Best regards,
> Krzysztof
Thanks,
Melody