2022-10-01 03:27:32

by Melody Olvera

[permalink] [raw]
Subject: [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs

This series firmware, SoC, rpmpd, tz-log, and mmc bindings as well as
pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.

This patchset is based off of [1] and [2] YAML conversion patches.

The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf

[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]

Melody Olvera (5):
dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards
dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding
soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains
soc: qcom: socinfo: Add QDU1000/QRU1000 and variant IDs

Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
.../devicetree/bindings/firmware/qcom,scm.yaml | 2 ++
.../devicetree/bindings/power/qcom,rpmpd.yaml | 2 ++
drivers/soc/qcom/rpmhpd.c | 13 +++++++++++++
drivers/soc/qcom/socinfo.c | 6 ++++++
include/dt-bindings/power/qcom-rpmpd.h | 6 ++++++
6 files changed, 45 insertions(+)


base-commit: 987a926c1d8a40e4256953b04771fbdb63bc7938
prerequisite-patch-id: 54cfdb75ec88e75b31d5c1df0d4a361434334d2b
prerequisite-patch-id: b0108c3601b8ed11cefe4366aa506b2dca364866
--
2.37.3


2022-10-01 03:58:37

by Melody Olvera

[permalink] [raw]
Subject: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards

Document the QDU1000 and QRU1000 SoC bindings and the boards that use
them.

Signed-off-by: Melody Olvera <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index fb1d00bcc847..1cfd92f4ab5d 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -61,6 +61,8 @@ description: |
sm8250
sm8350
sm8450
+ qdu1000
+ qru1000

The 'board' element must be one of the following strings:

@@ -76,6 +78,7 @@ description: |
mtp
qrd
sbc
+ x100

The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
where the minor number may be omitted when it's zero, i.e. v1.0 is the same
@@ -718,6 +721,19 @@ properties:
- qcom,sm8450-qrd
- const: qcom,sm8450

+ - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
+ - items:
+ - enum:
+ - qcom,qdu1000-idp
+ - qcom,qdu1000-x100
+ - const: qcom,qdu1000
+
+ - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
+ - items:
+ - enum:
+ -qcom,qru1000-idp
+ - const: qcom,qru1000
+
additionalProperties: true

...
--
2.37.3

2022-10-01 10:09:37

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards

On 01/10/2022 05:06, Melody Olvera wrote:
> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
> them.
>
> Signed-off-by: Melody Olvera <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++

This patch goes with DT.

> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..1cfd92f4ab5d 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -61,6 +61,8 @@ description: |
> sm8250
> sm8350
> sm8450
> + qdu1000
> + qru1000
>
> The 'board' element must be one of the following strings:
>
> @@ -76,6 +78,7 @@ description: |
> mtp
> qrd
> sbc
> + x100
>
> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
> @@ -718,6 +721,19 @@ properties:
> - qcom,sm8450-qrd
> - const: qcom,sm8450
>
> + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
> + - items:
> + - enum:
> + - qcom,qdu1000-idp
> + - qcom,qdu1000-x100
> + - const: qcom,qdu1000

Wrong order - you put it in some odd place.

> +
> + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
> + - items:
> + - enum:
> + -qcom,qru1000-idp

Missing space.

> + - const: qcom,qru1000
> +
> additionalProperties: true
>
> ...

Best regards,
Krzysztof

2022-10-01 10:40:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs

On 01/10/2022 05:06, Melody Olvera wrote:
> This series firmware, SoC, rpmpd, tz-log, and mmc bindings as well as
> pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
>
> This patchset is based off of [1] and [2] YAML conversion patches.

All of your patchsets were sent to wrong Bjorn's address. This means
either you based on mainline (which is reasonable but for some reason
address was not fixed in mainline...) or on some older linux-next.

I propose to rebase on recent linux-next, so you will get proper Bjorn's
email.

Best regards,
Krzysztof

2022-10-03 14:02:41

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards

On Fri, 30 Sep 2022 20:06:38 -0700, Melody Olvera wrote:
> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
> them.
>
> Signed-off-by: Melody Olvera <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/qcom.yaml:725:18: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/qcom.example.dts'
Documentation/devicetree/bindings/arm/qcom.yaml:725:18: mapping values are not allowed in this context
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/qcom.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/arm/qcom.yaml:725:18: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/qcom.yaml: ignoring, error parsing file
make: *** [Makefile:1420: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2022-10-04 15:23:06

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards


On 10/1/2022 4:26 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
>> them.
>>
>> Signed-off-by: Melody Olvera <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> This patch goes with DT.
Will move to the dt PS.
>
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index fb1d00bcc847..1cfd92f4ab5d 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -61,6 +61,8 @@ description: |
>> sm8250
>> sm8350
>> sm8450
>> + qdu1000
>> + qru1000
>>
>> The 'board' element must be one of the following strings:
>>
>> @@ -76,6 +78,7 @@ description: |
>> mtp
>> qrd
>> sbc
>> + x100
>>
>> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
>> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
>> @@ -718,6 +721,19 @@ properties:
>> - qcom,sm8450-qrd
>> - const: qcom,sm8450
>>
>> + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>> + - items:
>> + - enum:
>> + - qcom,qdu1000-idp
>> + - qcom,qdu1000-x100
>> + - const: qcom,qdu1000
> Wrong order - you put it in some odd place.
Will put in alphabetical order.
>
>> +
>> + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>> + - items:
>> + - enum:
>> + -qcom,qru1000-idp
> Missing space.
Whoops; will fix.
>
>> + - const: qcom,qru1000
>> +
>> additionalProperties: true
>>
>> ...
> Best regards,
> Krzysztof

Thanks,

Melody

2022-10-04 16:16:33

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs


On 10/1/2022 4:34 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> This series firmware, SoC, rpmpd, tz-log, and mmc bindings as well as
>> pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
>>
>> This patchset is based off of [1] and [2] YAML conversion patches.
> All of your patchsets were sent to wrong Bjorn's address. This means
> either you based on mainline (which is reasonable but for some reason
> address was not fixed in mainline...) or on some older linux-next.
>
> I propose to rebase on recent linux-next, so you will get proper Bjorn's
> email.
>
> Best regards,
> Krzysztof

Thanks Krzysztof. Yeah I figured that out; will add his most recent email in the next patchset. I was working on the tip of the linux-next stable branch, but does it make more sense to rebase on the master branch of linux-next prior to submitting?

Thanks,

Melody

2022-10-04 16:17:51

by Melody Olvera

[permalink] [raw]
Subject: Re: [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs



On 10/4/2022 10:27 AM, Melody Olvera wrote:
> On 10/1/2022 4:34 AM, Krzysztof Kozlowski wrote:
>> On 01/10/2022 05:06, Melody Olvera wrote:
>>> This series firmware, SoC, rpmpd, tz-log, and mmc bindings as well as
>>> pmic, rpmpd, and socinfo support for QDU1000 and QRU1000 SoCs.
>>>
>>> This patchset is based off of [1] and [2] YAML conversion patches.
>> All of your patchsets were sent to wrong Bjorn's address. This means
>> either you based on mainline (which is reasonable but for some reason
>> address was not fixed in mainline...) or on some older linux-next.
>>
>> I propose to rebase on recent linux-next, so you will get proper Bjorn's
>> email.
>>
>> Best regards,
>> Krzysztof
> Thanks Krzysztof. Yeah I figured that out; will add his most recent
> email in the next patchset. I was working on the tip of the linux-next
> stable branch, but does it make more sense to rebase on the master
> branch of linux-next prior to submitting?
> Thanks, Melody

Fixed formatting.