2022-09-29 07:06:06

by Randy Dunlap

[permalink] [raw]

Subject: [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO

---

The mt6370-charger driver uses IIO interfaces and produces build
errors when CONFIG_IIO is not set, so it should depend on IIO.

ERROR: modpost: "iio_read_channel_processed" [drivers/power/supply/mt6370-charger.ko] undefined!
ERROR: modpost: "devm_iio_channel_get_all" [drivers/power/supply/mt6370-charger.ko] undefined!

Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: ChiaEn Wu <[email protected]>
Cc: Sebastian Reichel <[email protected]>
Cc: [email protected]
---
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -623,6 +623,7 @@ config CHARGER_MT6370
tristate "MediaTek MT6370 Charger Driver"
depends on MFD_MT6370
depends on REGULATOR
+ depends on IIO
select LINEAR_RANGES
help
Say Y here to enable MT6370 Charger Part.

2022-10-01 20:48:26

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO

---

Hi,

On Wed, Sep 28, 2022 at 11:29:40PM -0700, Randy Dunlap wrote:
> The mt6370-charger driver uses IIO interfaces and produces build
> errors when CONFIG_IIO is not set, so it should depend on IIO.
>
> ERROR: modpost: "iio_read_channel_processed" [drivers/power/supply/mt6370-charger.ko] undefined!
> ERROR: modpost: "devm_iio_channel_get_all" [drivers/power/supply/mt6370-charger.ko] undefined!
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: ChiaEn Wu <[email protected]>
> Cc: Sebastian Reichel <[email protected]>
> Cc: [email protected]
> ---
> drivers/power/supply/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
> tristate "MediaTek MT6370 Charger Driver"
> depends on MFD_MT6370
> depends on REGULATOR
> + depends on IIO
> select LINEAR_RANGES
> help
> Say Y here to enable MT6370 Charger Part.

Thanks, queued.

-- Sebastian

---

Attachments:

(No filename) (1.10 kB)
signature.asc (849.00 B)
Download all attachments