This series converts two functions return type from u8 to void as
part of getting rid of _FAIL / _SUCCESS.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (2):
staging: r8188eu: convert rtw_reset_drv_sw() to void
staging: r8188eu: convert rtw_free_drv_sw() to void
drivers/staging/r8188eu/include/osdep_intf.h | 4 ++--
drivers/staging/r8188eu/os_dep/os_intfs.c | 8 ++------
2 files changed, 4 insertions(+), 8 deletions(-)
--
2.37.3
The function rtw_free_drv_sw() always returns _SUCCESS. None of its
callers use the return value. Convert the return type of that function
from u8 to void. This is part of getting rid of _FAIL / _SUCCESS.
Signed-off-by: Michael Straube <[email protected]>
---
drivers/staging/r8188eu/include/osdep_intf.h | 2 +-
drivers/staging/r8188eu/os_dep/os_intfs.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/include/osdep_intf.h b/drivers/staging/r8188eu/include/osdep_intf.h
index ce8e1bc4a61c..0f7d74a3ff6d 100644
--- a/drivers/staging/r8188eu/include/osdep_intf.h
+++ b/drivers/staging/r8188eu/include/osdep_intf.h
@@ -43,7 +43,7 @@ int netdev_open(struct net_device *pnetdev);
int netdev_close(struct net_device *pnetdev);
u8 rtw_init_drv_sw(struct adapter *padapter);
-u8 rtw_free_drv_sw(struct adapter *padapter);
+void rtw_free_drv_sw(struct adapter *padapter);
void rtw_reset_drv_sw(struct adapter *padapter);
u32 rtw_start_drv_threads(struct adapter *padapter);
diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
index 2983e665bd5c..38e324754c8f 100644
--- a/drivers/staging/r8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
@@ -548,7 +548,7 @@ void rtw_cancel_all_timer(struct adapter *padapter)
_cancel_timer_ex(&padapter->recvpriv.signal_stat_timer);
}
-u8 rtw_free_drv_sw(struct adapter *padapter)
+void rtw_free_drv_sw(struct adapter *padapter)
{
/* we can call rtw_p2p_enable here, but: */
/* 1. rtw_p2p_enable may have IO operation */
@@ -585,8 +585,6 @@ u8 rtw_free_drv_sw(struct adapter *padapter)
/* clear pbuddystruct adapter to avoid access wrong pointer. */
if (padapter->pbuddy_adapter)
padapter->pbuddy_adapter->pbuddy_adapter = NULL;
-
- return _SUCCESS;
}
void netdev_br_init(struct net_device *netdev)
--
2.37.3
On 10/2/22 16:35, Michael Straube wrote:
> This series converts two functions return type from u8 to void as
> part of getting rid of _FAIL / _SUCCESS.
>
> Tested on x86_64 with Inter-Tech DMG-02.
>
> Michael Straube (2):
> staging: r8188eu: convert rtw_reset_drv_sw() to void
> staging: r8188eu: convert rtw_free_drv_sw() to void
>
> drivers/staging/r8188eu/include/osdep_intf.h | 4 ++--
> drivers/staging/r8188eu/os_dep/os_intfs.c | 8 ++------
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
Tested-by: Philipp Hortmann <[email protected]> # Edimax N150