2022-10-21 14:26:42

by Amjad Ouled-Ameur

[permalink] [raw]
Subject: [PATCH v4 4/4] arm64: dts: meson-gxbb: add SPI pinctrl nodes for CLK

Add SPICC Controller pin nodes for CLK line when idle for Amlogic GXBB
SoCs.

Signed-off-by: Amjad Ouled-Ameur <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 7c029f552a23..923d2d8bbb9c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -427,6 +427,20 @@ mux {
};
};

+ spi_idle_high_pins: spi-idle-high-pins {
+ mux {
+ groups = "spi_sclk";
+ bias-pull-up;
+ };
+ };
+
+ spi_idle_low_pins: spi-idle-low-pins {
+ mux {
+ groups = "spi_sclk";
+ bias-pull-down;
+ };
+ };
+
spi_ss0_pins: spi-ss0 {
mux {
groups = "spi_ss0";

--
b4 0.10.1


2022-10-21 14:27:24

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v4 4/4] arm64: dts: meson-gxbb: add SPI pinctrl nodes for CLK

On 21/10/2022 15:31, Amjad Ouled-Ameur wrote:
> Add SPICC Controller pin nodes for CLK line when idle for Amlogic GXBB
> SoCs.
>
> Signed-off-by: Amjad Ouled-Ameur <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 7c029f552a23..923d2d8bbb9c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -427,6 +427,20 @@ mux {
> };
> };
>
> + spi_idle_high_pins: spi-idle-high-pins {
> + mux {
> + groups = "spi_sclk";
> + bias-pull-up;
> + };
> + };
> +
> + spi_idle_low_pins: spi-idle-low-pins {
> + mux {
> + groups = "spi_sclk";
> + bias-pull-down;
> + };
> + };
> +
> spi_ss0_pins: spi-ss0 {
> mux {
> groups = "spi_ss0";
>


Reviewed-by: Neil Armstrong <[email protected]>

2022-10-22 11:22:38

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH v4 4/4] arm64: dts: meson-gxbb: add SPI pinctrl nodes for CLK

On Fri, Oct 21, 2022 at 3:31 PM Amjad Ouled-Ameur
<[email protected]> wrote:
>
> Add SPICC Controller pin nodes for CLK line when idle for Amlogic GXBB
> SoCs.
>
> Signed-off-by: Amjad Ouled-Ameur <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>