2022-10-05 05:06:22

by Chaitanya Kulkarni

[permalink] [raw]
Subject: [RFC PATCH 08/18] n64cart: use init disk helper

Add and use the helper to initialize the common fields of struct gendisk
such as major, first_minor, minors, disk_name, private_data, and ops.
This initialization is spread all over the block drivers. This avoids
code repetation of inialization code of gendisk in current block drivers
and any future ones.

Signed-off-by: Chaitanya Kulkarni <[email protected]>
---
drivers/block/n64cart.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index d914156db2d8..28b32fbe6586 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -135,14 +135,12 @@ static int __init n64cart_probe(struct platform_device *pdev)
if (!disk)
goto out;

- disk->first_minor = 0;
disk->flags = GENHD_FL_NO_PART;
disk->fops = &n64cart_fops;
- disk->private_data = &pdev->dev;
strcpy(disk->disk_name, "n64cart");

- set_capacity(disk, size >> SECTOR_SHIFT);
set_disk_ro(disk, 1);
+ init_disk(disk, 0, 0, 0, size >> 9, &pdev->dev, &n64cart_fops);

blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
blk_queue_physical_block_size(disk->queue, 4096);
--
2.29.0