Hi,
Patches are organized not by file, but rather type of change
1. First patches is for common TLMM schema and dropping unneeded refs.
2. Last patches are pure cleanups without functional impact.
Overview
========
This is the *fifth* patchset around Qualcomm pinctrl in recent days:
1. First round of TLMM fixes: merged
2. LPASS fixes:
https://lore.kernel.org/linux-devicetree/[email protected]/
3. ARMv7 TLMM fixes:
https://lore.kernel.org/linux-devicetree/[email protected]/
4. ARMv8 remaining TLMM fixes:
https://lore.kernel.org/linux-devicetree/[email protected]/
5. Fifth clean - styles and using common TLMM schema: *THIS PATCHSET*
Dependencies
============
1. Almost no dependencies - logically the bindings patch "dt-bindings: pinctrl:
qcom,sm8250: drop checks used in common TLMM" depends on patchset #3 above.
This is not a hard-dependency, everything will compile nicely, no warnings.
2. dt-bindings are independent of DTS patches.
Best regards,
Krzysztof
Krzysztof Kozlowski (34):
dt-bindings: pinctrl: qcom,mdm9607: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sc7280: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sc8180x: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sc8180x: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sc8280xp: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sm6115: use common TLMM schema
dt-bindings: pinctrl: qcom,sm6125: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sm6125: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sm6350: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sm6350: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sm6375-tlmm: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sm6375-tlmm: drop checks used in common
TLMM
dt-bindings: pinctrl: qcom,sm8250: use common TLMM schema
dt-bindings: pinctrl: qcom,sm8350: drop ref to pinctrl.yaml
dt-bindings: pinctrl: qcom,sm8350: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,sm8450: drop checks used in common TLMM
dt-bindings: pinctrl: qcom,mdm9607: minor style cleanups
dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups
dt-bindings: pinctrl: qcom,qcm2290: minor style cleanups
dt-bindings: pinctrl: qcom,sdx65: minor style cleanups
dt-bindings: pinctrl: qcom,sc8180x: minor style cleanups
dt-bindings: pinctrl: qcom,sc8280xp: minor style cleanups
dt-bindings: pinctrl: qcom,sm6115: minor style cleanups
dt-bindings: pinctrl: qcom,sm6125: minor style cleanups
dt-bindings: pinctrl: qcom,sm6350: minor style cleanups
dt-bindings: pinctrl: qcom,sm6375: minor style cleanups
dt-bindings: pinctrl: qcom,sm8250: minor style cleanups
dt-bindings: pinctrl: qcom,sm8350: minor style cleanups
dt-bindings: pinctrl: qcom,sm8450: minor style cleanups
dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: minor style cleanups
dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: minor style cleanups
dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: minor style cleanups
dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups
dt-bindings: pinctrl: qcom: adjust description
.../pinctrl/qcom,ipq6018-pinctrl.yaml | 5 +-
.../pinctrl/qcom,mdm9607-pinctrl.yaml | 16 ++---
.../pinctrl/qcom,msm8226-pinctrl.yaml | 5 +-
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 ++-
.../pinctrl/qcom,msm8953-pinctrl.yaml | 5 +-
.../pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++-
.../qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++--
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 16 +----
.../pinctrl/qcom,sc8180x-pinctrl.yaml | 27 +++----
.../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++--
.../pinctrl/qcom,sc8280xp-pinctrl.yaml | 22 ++----
.../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 +-
.../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++-
.../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 53 +++-----------
.../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 30 +++-----
.../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 23 ++----
.../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 23 ++----
.../qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 ++---
.../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 70 ++++++-------------
.../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 23 ++----
.../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++--
.../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++----
22 files changed, 136 insertions(+), 295 deletions(-)
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
index 0b251caaebf2..886d4e76af44 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
@@ -53,6 +53,7 @@ patternProperties:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -113,16 +114,6 @@ patternProperties:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-1][0-9]|22[0-7])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
index 8320e5ff17b9..4482625b6b1f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
@@ -53,6 +53,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -119,16 +120,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-6])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
index 843d110df240..50f721d5f843 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
@@ -13,7 +13,6 @@ description: |
in the SM6125 platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
index 3f5f5229a86c..c6b8e8929e61 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
@@ -10,8 +10,8 @@ maintainers:
- Iskren Chernev <[email protected]>
description:
- This binding describes the Top Level Mode Multiplexer block found in the
- SM4250/6115 platforms.
+ Top Level Mode Multiplexer pin controller in Qualcomm SM4250 and SM6115
+ SoCs.
properties:
compatible:
@@ -36,9 +36,8 @@ properties:
gpio-reserved-ranges: true
wakeup-parent: true
-#PIN CONFIGURATION NODES
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm6115-tlmm-state"
- patternProperties:
@@ -46,7 +45,7 @@ patternProperties:
$ref: "#/$defs/qcom-sm6115-tlmm-state"
additionalProperties: false
-'$defs':
+$defs:
qcom-sm6115-tlmm-state:
type: object
description:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
index 1c0186050dcc..cae726b5fc79 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
@@ -53,6 +53,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -107,16 +108,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-3])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
Reference common Qualcomm TLMM pin controller schema, to bring common
properties, other pinctrl schemas and additional checks, like function
required only for GPIOs.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 44 +++----------------
1 file changed, 6 insertions(+), 38 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
index e39fbb36d8c1..3f5f5229a86c 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
@@ -27,30 +27,13 @@ properties:
- const: south
- const: east
- interrupts:
- description: Specifies the TLMM summary IRQ
- maxItems: 1
-
+ interrupts: true
interrupt-controller: true
-
- '#interrupt-cells':
- description:
- Specifies the PIN numbers and Flags, as defined in defined in
- include/dt-bindings/interrupt-controller/irq.h
- const: 2
-
+ "#interrupt-cells": true
gpio-controller: true
-
- '#gpio-cells':
- description: Specifying the pin number and flags, as defined in
- include/dt-bindings/gpio/gpio.h
- const: 2
-
- gpio-ranges:
- maxItems: 1
-
+ "#gpio-cells": true
+ gpio-ranges: true
gpio-reserved-ranges: true
-
wakeup-parent: true
#PIN CONFIGURATION NODES
@@ -69,6 +52,7 @@ patternProperties:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -120,31 +104,15 @@ patternProperties:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
- then:
- required:
- - function
-
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
- reg
- reg-names
- - interrupts
- - interrupt-controller
- - '#interrupt-cells'
- - gpio-controller
- - '#gpio-cells'
- - gpio-ranges
additionalProperties: false
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
index 6ae5571f60da..1c0186050dcc 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
@@ -14,7 +14,6 @@ description: |
in the SM8350 platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
Drop "binding" from description, because the field should describe the
hardware.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 5 ++---
.../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 5 ++---
.../devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 5 ++---
.../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 5 ++---
.../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 ++---
6 files changed, 11 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index bf84649593ef..6f9b92afb621 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. IPQ6018 TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- IPQ6018 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm IPQ6018 SoC.
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
index 23868cdf4e03..3874908ff7de 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. MSM8226 TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- MSM8226 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm MSM8226 SoC.
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
index 19d16cc9d749..5c6a0d057787 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. MSM8953 TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- MSM8953 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm MSM8953 SoC.
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
index bdb896e5682f..5f87f15dcd1a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SC7280 TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- SC7280 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SC7280 SoC.
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
index 071f416f74b2..52e5571cfbf0 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
@@ -10,7 +10,7 @@ maintainers:
- Bjorn Andersson <[email protected]>
description:
- Top Level Mode Multiplexer pin controller node in Qualcomm SC8180X SoC.
+ Top Level Mode Multiplexer pin controller in Qualcomm SC8180X SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
index 2d7097edfb40..00116a045f6e 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SDX55 TLMM block
maintainers:
- Vinod Koul <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- SDX55 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SDX55 SoC.
properties:
compatible:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
index ad1a2446a8af..c0f349b88002 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx65-pinctrl.yaml
@@ -10,8 +10,7 @@ maintainers:
- Vamsi krishna Lanka <[email protected]>
description:
- This binding describes the Top Level Mode Multiplexer block found in the
- SDX65 platform.
+ Top Level Mode Multiplexer pin controller in Qualcomm SDX65 SoC.
properties:
compatible:
@@ -30,9 +29,8 @@ properties:
gpio-reserved-ranges:
maxItems: 1
-#PIN CONFIGURATION NODES
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sdx65-tlmm-state"
- patternProperties:
@@ -40,13 +38,13 @@ patternProperties:
$ref: "#/$defs/qcom-sdx65-tlmm-state"
additionalProperties: false
-'$defs':
+$defs:
qcom-sdx65-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
index 7ab9a0eec017..e0caa06b84a4 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SM8450 TLMM block
maintainers:
- Vinod Koul <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the SM8450 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SM8450 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,7 +24,7 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges:
@@ -35,7 +34,7 @@ properties:
gpio-line-names:
maxItems: 209
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -46,7 +45,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm8450-tlmm-state"
- patternProperties:
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index a37b358715a3..5a9002a83423 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -14,7 +14,6 @@ description: |
MDM9607 platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
index 0d73abeea715..1376031661d7 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
@@ -10,8 +10,7 @@ maintainers:
- Shawn Guo <[email protected]>
description:
- This binding describes the Top Level Mode Multiplexer block found in the
- QCM2290 platform.
+ Top Level Mode Multiplexer pin controller in Qualcomm QCM2290 SoC.
properties:
compatible:
@@ -28,9 +27,8 @@ properties:
gpio-ranges: true
wakeup-parent: true
-#PIN CONFIGURATION NODES
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-qcm2290-tlmm-state"
- patternProperties:
@@ -38,13 +36,13 @@ patternProperties:
$ref: "#/$defs/qcom-qcm2290-tlmm-state"
additionalProperties: false
-'$defs':
+$defs:
qcom-qcm2290-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
index 894e59caa735..38355409fe43 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SM6350 TLMM block
maintainers:
- Konrad Dybcio <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the SM6350 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SM6350 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,7 +38,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm6350-tlmm-state"
- patternProperties:
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
index b98eeba2c530..62d0ea7bbc62 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
@@ -14,7 +14,6 @@ description: |
SC8180X platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
index edf38c774514..7d2589387e1a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml
@@ -4,15 +4,14 @@
$id: http://devicetree.org/schemas/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
- Low Power Island (LPI) TLMM block
+title: Qualcomm SC8280XP SoC LPASS LPI TLMM
maintainers:
- Srinivas Kandagatla <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- LPASS LPI IP on most Qualcomm SoCs
+description:
+ Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem
+ (LPASS) Low Power Island (LPI) of Qualcomm SC8280XP SoC.
properties:
compatible:
@@ -35,7 +34,7 @@ properties:
gpio-controller: true
- '#gpio-cells':
+ "#gpio-cells":
description: Specifying the pin number and flags, as defined in
include/dt-bindings/gpio/gpio.h
const: 2
@@ -120,7 +119,7 @@ required:
- clocks
- clock-names
- gpio-controller
- - '#gpio-cells'
+ - "#gpio-cells"
- gpio-ranges
additionalProperties: false
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
index 62d0ea7bbc62..71ca4cfd567c 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
@@ -60,6 +60,7 @@ patternProperties:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -111,16 +112,6 @@ patternProperties:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-8][0-9])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
index bd54c92287d6..8270debd4f25 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
@@ -4,15 +4,14 @@
$id: http://devicetree.org/schemas/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
- Low Power Island (LPI) TLMM block
+title: Qualcomm SC7280 SoC LPASS LPI TLMM
maintainers:
- Srinivas Kandagatla <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- LPASS LPI IP on most Qualcomm SoCs
+description:
+ Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem
+ (LPASS) Low Power Island (LPI) of Qualcomm SC7280 SoC.
properties:
compatible:
@@ -29,7 +28,7 @@ properties:
gpio-controller: true
- '#gpio-cells':
+ "#gpio-cells":
description: Specifying the pin number and flags, as defined in
include/dt-bindings/gpio/gpio.h
const: 2
@@ -107,7 +106,7 @@ required:
- compatible
- reg
- gpio-controller
- - '#gpio-cells'
+ - "#gpio-cells"
- gpio-ranges
additionalProperties: false
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
index cae726b5fc79..2a7be4522aea 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SM8350 TLMM block
maintainers:
- Vinod Koul <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the SM8350 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SM8350 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,7 +38,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm8350-tlmm-state"
- patternProperties:
--
2.34.1
Reference common Qualcomm TLMM pin controller schema, to bring common
properties, other pinctrl schemas and additional checks, like function
required only for GPIOs.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 34 ++++---------------
1 file changed, 6 insertions(+), 28 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
index fb753fd8bbee..824a4dce1202 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
@@ -27,27 +27,13 @@ properties:
- const: "south"
- const: "north"
- interrupts:
- description: Specifies the TLMM summary IRQ
- maxItems: 1
-
+ interrupts: true
interrupt-controller: true
-
- '#interrupt-cells':
- description:
- Specifies the PIN numbers and Flags, as defined in defined in
- include/dt-bindings/interrupt-controller/irq.h
- const: 2
-
+ "#interrupt-cells": true
gpio-controller: true
-
- '#gpio-cells':
- description: Specifying the pin number and flags, as defined in
- include/dt-bindings/gpio/gpio.h
- const: 2
-
- gpio-ranges:
- maxItems: 1
+ "#gpio-cells": true
+ gpio-ranges: true
+ wakeup-parent: true
gpio-reserved-ranges:
minItems: 1
@@ -56,8 +42,6 @@ properties:
gpio-line-names:
maxItems: 180
- wakeup-parent: true
-
patternProperties:
"-state$":
oneOf:
@@ -129,18 +113,12 @@ $defs:
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
required:
- compatible
- reg
- reg-names
- - interrupts
- - interrupt-controller
- - '#interrupt-cells'
- - gpio-controller
- - '#gpio-cells'
- - gpio-ranges
additionalProperties: false
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), drop redundant minItems, use double quotes
consistently and drop redundant quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 36 +++++++++----------
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
index 824a4dce1202..1e42a4c60da9 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
@@ -9,23 +9,21 @@ title: Qualcomm Technologies, Inc. SM8250 TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- SM8250 platform.
+description:
+ Top Level Mode Multiplexer pin controller in the Qualcomm SM8250 SoC.
properties:
compatible:
const: qcom,sm8250-pinctrl
reg:
- minItems: 3
maxItems: 3
reg-names:
items:
- - const: "west"
- - const: "south"
- - const: "north"
+ - const: west
+ - const: south
+ - const: north
interrupts: true
interrupt-controller: true
@@ -126,16 +124,16 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
pinctrl@1f00000 {
- compatible = "qcom,sm8250-pinctrl";
- reg = <0x0f100000 0x300000>,
- <0x0f500000 0x300000>,
- <0x0f900000 0x300000>;
- reg-names = "west", "south", "north";
- interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- gpio-ranges = <&tlmm 0 0 180>;
- wakeup-parent = <&pdc>;
+ compatible = "qcom,sm8250-pinctrl";
+ reg = <0x0f100000 0x300000>,
+ <0x0f500000 0x300000>,
+ <0x0f900000 0x300000>;
+ reg-names = "west", "south", "north";
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 180>;
+ wakeup-parent = <&pdc>;
};
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
index 5a9002a83423..f832d776e1ab 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. MDM9607 TLMM block
maintainers:
- Konrad Dybcio <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- MDM9607 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm MDM9607 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,20 +38,20 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-mdm9607-tlmm-state"
- patternProperties:
".*":
$ref: "#/$defs/qcom-mdm9607-tlmm-state"
-'$defs':
+$defs:
qcom-mdm9607-tlmm-state:
type: object
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
index 5cb8b272cb7d..843d110df240 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
@@ -61,6 +61,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -112,16 +113,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio[0-9]|[1-9][0-9]|1[0-2][0-9]|13[0-2]$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
index 4482625b6b1f..d54ebb2bd5a8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SM6375 TLMM block
maintainers:
- Konrad Dybcio <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the SM6375 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SM6375 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,7 +38,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm6375-tlmm-state"
- patternProperties:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
index 886d4e76af44..ec0e4bf9e0af 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml
@@ -10,8 +10,7 @@ maintainers:
- Bjorn Andersson <[email protected]>
description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- SC8280XP platform.
+ Top Level Mode Multiplexer pin controller in Qualcomm SC8280XP SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,7 +38,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sc8280xp-tlmm-state"
- patternProperties:
@@ -47,7 +46,7 @@ patternProperties:
$ref: "#/$defs/qcom-sc8280xp-tlmm-state"
additionalProperties: false
-'$defs':
+$defs:
qcom-sc8280xp-tlmm-state:
type: object
description:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
index 71ca4cfd567c..071f416f74b2 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml
@@ -9,9 +9,8 @@ title: Qualcomm Technologies, Inc. SC8180X TLMM block
maintainers:
- Bjorn Andersson <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- SC8180X platform.
+description:
+ Top Level Mode Multiplexer pin controller node in Qualcomm SC8180X SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,9 +24,9 @@ properties:
reg-names:
items:
- - const: "west"
- - const: "east"
- - const: "south"
+ - const: west
+ - const: east
+ - const: south
interrupts: true
interrupt-controller: true
@@ -46,7 +45,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sc8180x-tlmm-state"
- patternProperties:
@@ -54,7 +53,7 @@ patternProperties:
$ref: "#/$defs/qcom-sc8180x-tlmm-state"
additionalProperties: false
-'$defs':
+$defs:
qcom-sc8180x-tlmm-state:
type: object
description:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
index 94af82ee5967..894e59caa735 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
@@ -53,6 +53,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -110,16 +111,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-7])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
index 9cd97a467648..7ab9a0eec017 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-pinctrl.yaml
@@ -60,6 +60,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -112,16 +113,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-9])$"
- then:
- required:
- - function
-
additionalProperties: false
examples:
--
2.34.1
The common Qualcomm TLMM pin controller schema already brings
requirement of function for GPIO pins.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
index 2a6b5a719d18..bdb896e5682f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml
@@ -62,6 +62,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
@@ -127,16 +128,6 @@ $defs:
required:
- pins
- allOf:
- - $ref: /schemas/pinctrl/pincfg-node.yaml
- - if:
- properties:
- pins:
- pattern: "^gpio([0-9]|[1-9][0-9]|1[0-6][0-9]|17[0-4])$"
- then:
- required:
- - function
-
additionalProperties: false
allOf:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml
index c81fd74cde1a..01a0a4a40ba5 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml
@@ -4,15 +4,14 @@
$id: http://devicetree.org/schemas/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
- Low Power Island (LPI) TLMM block
+title: Qualcomm SM8450 SoC LPASS LPI TLMM
maintainers:
- Srinivas Kandagatla <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- LPASS LPI IP on most Qualcomm SoCs
+description:
+ Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem
+ (LPASS) Low Power Island (LPI) of Qualcomm SM8450 SoC.
properties:
compatible:
@@ -35,7 +34,7 @@ properties:
gpio-controller: true
- '#gpio-cells':
+ "#gpio-cells":
description: Specifying the pin number and flags, as defined in
include/dt-bindings/gpio/gpio.h
const: 2
@@ -122,7 +121,7 @@ required:
- clocks
- clock-names
- gpio-controller
- - '#gpio-cells'
+ - "#gpio-cells"
- gpio-ranges
additionalProperties: false
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), drop redundant minItems, use double quotes
consistently and drop redundant quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml
index 290ba2375e92..bd45faa3f078 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml
@@ -4,22 +4,20 @@
$id: http://devicetree.org/schemas/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
- Low Power Island (LPI) TLMM block
+title: Qualcomm SM8250 SoC LPASS LPI TLMM
maintainers:
- Srinivas Kandagatla <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer block found in the
- LPASS LPI IP on most Qualcomm SoCs
+description:
+ Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem
+ (LPASS) Low Power Island (LPI) of Qualcomm SM8250 SoC.
properties:
compatible:
const: qcom,sm8250-lpass-lpi-pinctrl
reg:
- minItems: 2
maxItems: 2
clocks:
@@ -34,7 +32,7 @@ properties:
gpio-controller: true
- '#gpio-cells':
+ "#gpio-cells":
description: Specifying the pin number and flags, as defined in
include/dt-bindings/gpio/gpio.h
const: 2
@@ -110,7 +108,7 @@ $defs:
additionalProperties: false
allOf:
- - $ref: "pinctrl.yaml#"
+ - $ref: pinctrl.yaml#
required:
- compatible
@@ -118,7 +116,7 @@ required:
- clocks
- clock-names
- gpio-controller
- - '#gpio-cells'
+ - "#gpio-cells"
- gpio-ranges
additionalProperties: false
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
index 025faf87d147..8320e5ff17b9 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml
@@ -14,7 +14,6 @@ description: |
in the SM6375 platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
index 9c647e24fa9a..cc6d0c9c5100 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
@@ -10,8 +10,7 @@ maintainers:
- Stephan Gerhold <[email protected]>
description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the MSM8909 platform.
+ Top Level Mode Multiplexer pin controller in Qualcomm MSM8909 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -25,10 +24,10 @@ properties:
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -39,7 +38,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-msm8909-tlmm-state"
- patternProperties:
@@ -53,7 +52,7 @@ $defs:
description:
Pinctrl node's client devices use subnodes for desired pin configuration.
Client device subnodes use below standard properties.
- $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
properties:
pins:
--
2.34.1
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), drop redundant minItems, use double quotes
consistently and drop redundant quotes.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
index 50f721d5f843..6258e3f37e0c 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml
@@ -8,9 +8,8 @@ title: Qualcomm Technologies, Inc. SM6125 TLMM block
maintainers:
- Martin Botka <[email protected]>
-description: |
- This binding describes the Top Level Mode Multiplexer (TLMM) block found
- in the SM6125 platform.
+description:
+ Top Level Mode Multiplexer pin controller in Qualcomm SM6125 SoC.
allOf:
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
@@ -20,21 +19,20 @@ properties:
const: qcom,sm6125-tlmm
reg:
- minItems: 3
maxItems: 3
reg-names:
items:
- - const: "west"
- - const: "south"
- - const: "east"
+ - const: west
+ - const: south
+ - const: east
interrupts: true
interrupt-controller: true
- '#interrupt-cells': true
+ "#interrupt-cells": true
gpio-controller: true
gpio-reserved-ranges: true
- '#gpio-cells': true
+ "#gpio-cells": true
gpio-ranges: true
wakeup-parent: true
@@ -46,7 +44,7 @@ required:
additionalProperties: false
patternProperties:
- '-state$':
+ "-state$":
oneOf:
- $ref: "#/$defs/qcom-sm6125-tlmm-state"
- patternProperties:
--
2.34.1
The binding references common Qualcomm TLMM pin controller schema, which
references pinctrl.yaml.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
index 856b9c567ecb..94af82ee5967 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml
@@ -14,7 +14,6 @@ description: |
in the SM6350 platform.
allOf:
- - $ref: "pinctrl.yaml#"
- $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
properties:
--
2.34.1
On Thu, Oct 06, 2022 at 04:06:21PM +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Thanks for all the cleanup!
FWIW:
Acked-by: Stephan Gerhold <[email protected]>
> ---
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> index 9c647e24fa9a..cc6d0c9c5100 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> @@ -10,8 +10,7 @@ maintainers:
> - Stephan Gerhold <[email protected]>
>
> description: |
> - This binding describes the Top Level Mode Multiplexer (TLMM) block found
> - in the MSM8909 platform.
> + Top Level Mode Multiplexer pin controller in Qualcomm MSM8909 SoC.
>
> allOf:
> - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
> @@ -25,10 +24,10 @@ properties:
>
> interrupts: true
> interrupt-controller: true
> - '#interrupt-cells': true
> + "#interrupt-cells": true
> gpio-controller: true
> gpio-reserved-ranges: true
> - '#gpio-cells': true
> + "#gpio-cells": true
> gpio-ranges: true
> wakeup-parent: true
>
> @@ -39,7 +38,7 @@ required:
> additionalProperties: false
>
> patternProperties:
> - '-state$':
> + "-state$":
> oneOf:
> - $ref: "#/$defs/qcom-msm8909-tlmm-state"
> - patternProperties:
> @@ -53,7 +52,7 @@ $defs:
> description:
> Pinctrl node's client devices use subnodes for desired pin configuration.
> Client device subnodes use below standard properties.
> - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
> + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
>
> properties:
> pins:
> --
> 2.34.1
>
Hi Krzysztof,
On Thu, Oct 06, 2022 at 04:06:03PM +0200, Krzysztof Kozlowski wrote:
> [...]
> Krzysztof Kozlowski (34):
> dt-bindings: pinctrl: qcom,mdm9607: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sc7280: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sc8180x: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sc8180x: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sc8280xp: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6115: use common TLMM schema
> dt-bindings: pinctrl: qcom,sm6125: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6125: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6350: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6350: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6375-tlmm: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6375-tlmm: drop checks used in common
> TLMM
> dt-bindings: pinctrl: qcom,sm8250: use common TLMM schema
> dt-bindings: pinctrl: qcom,sm8350: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm8350: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm8450: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,mdm9607: minor style cleanups
> dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups
> dt-bindings: pinctrl: qcom,qcm2290: minor style cleanups
> dt-bindings: pinctrl: qcom,sdx65: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8180x: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8280xp: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6115: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6125: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6350: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6375: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8250: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8350: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8450: minor style cleanups
> dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom: adjust description
>
> .../pinctrl/qcom,ipq6018-pinctrl.yaml | 5 +-
> .../pinctrl/qcom,mdm9607-pinctrl.yaml | 16 ++---
> .../pinctrl/qcom,msm8226-pinctrl.yaml | 5 +-
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 ++-
> .../pinctrl/qcom,msm8953-pinctrl.yaml | 5 +-
> .../pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++-
> .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++--
> .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 16 +----
> .../pinctrl/qcom,sc8180x-pinctrl.yaml | 27 +++----
> .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++--
> .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 22 ++----
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 +-
> .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++-
> .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 53 +++-----------
> .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 30 +++-----
> .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 23 ++----
> .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 23 ++----
> .../qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 ++---
> .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 70 ++++++-------------
> .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 23 ++----
> .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++--
> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++----
Just a random thought since you are already doing minor style cleanups
here: Some of these files are named incorrectly, e.g. qcom,sm8450-pinctrl.yaml
actually documents "qcom,sm8450-tlmm". I noticed this while adding
qcom,msm8909-tlmm but I have to admit that it did not bother me enough
to actually prepare a patch for this (and now it would just conflict
with all your patches). :)
No need to change anything here, just thought I'd mention it.
Thanks!
Stephan
On Thu, 06 Oct 2022 16:06:05 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:16 +0200, Krzysztof Kozlowski wrote:
> Reference common Qualcomm TLMM pin controller schema, to bring common
> properties, other pinctrl schemas and additional checks, like function
> required only for GPIOs.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 34 ++++---------------
> 1 file changed, 6 insertions(+), 28 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:09 +0200, Krzysztof Kozlowski wrote:
> Reference common Qualcomm TLMM pin controller schema, to bring common
> properties, other pinctrl schemas and additional checks, like function
> required only for GPIOs.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 44 +++----------------
> 1 file changed, 6 insertions(+), 38 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:17 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:15 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:14 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:20 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:23 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:30 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), drop redundant minItems, use double quotes
> consistently and drop redundant quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 36 +++++++++----------
> 1 file changed, 17 insertions(+), 19 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:33 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:08 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:07 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:24 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:10 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:04 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:21 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:06 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:34 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), drop redundant minItems, use double quotes
> consistently and drop redundant quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:11 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:25 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc8280xp-pinctrl.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:12 +0200, Krzysztof Kozlowski wrote:
> The binding references common Qualcomm TLMM pin controller schema, which
> references pinctrl.yaml.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:36 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On 06/10/2022 17:49, Stephan Gerhold wrote:
>> .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++--
>> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++----
>
> Just a random thought since you are already doing minor style cleanups
> here: Some of these files are named incorrectly, e.g. qcom,sm8450-pinctrl.yaml
> actually documents "qcom,sm8450-tlmm". I noticed this while adding
> qcom,msm8909-tlmm but I have to admit that it did not bother me enough
> to actually prepare a patch for this (and now it would just conflict
> with all your patches). :)
>
> No need to change anything here, just thought I'd mention it.
Sure, I can change this as well. Thanks for sharing!
Best regards,
Krzysztof
On Thu, 06 Oct 2022 16:06:22 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:26 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:35 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:19 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:18 +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema already brings
> requirement of function for GPIO pins.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:29 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:37 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description, because the field should describe the
> hardware.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 5 ++---
> .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 5 ++---
> .../devicetree/bindings/pinctrl/qcom,msm8953-pinctrl.yaml | 5 ++---
> .../devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 5 ++---
> .../devicetree/bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 ++---
> 6 files changed, 11 insertions(+), 16 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:27 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), drop redundant minItems, use double quotes
> consistently and drop redundant quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:31 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:28 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Thu, 06 Oct 2022 16:06:32 +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On 10/6/22 17:06, Krzysztof Kozlowski wrote:
> Reference common Qualcomm TLMM pin controller schema, to bring common
> properties, other pinctrl schemas and additional checks, like function
> required only for GPIOs.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Iskren Chernev <[email protected]>
On Thu, Oct 6, 2022 at 4:06 PM Krzysztof Kozlowski
<[email protected]> wrote:
> Patches are organized not by file, but rather type of change
> 1. First patches is for common TLMM schema and dropping unneeded refs.
> 2. Last patches are pure cleanups without functional impact.
>
> Overview
> ========
> This is the *fifth* patchset around Qualcomm pinctrl in recent days:
> 1. First round of TLMM fixes: merged
> 2. LPASS fixes:
> https://lore.kernel.org/linux-devicetree/[email protected]/
> 3. ARMv7 TLMM fixes:
> https://lore.kernel.org/linux-devicetree/[email protected]/
> 4. ARMv8 remaining TLMM fixes:
> https://lore.kernel.org/linux-devicetree/[email protected]/
> 5. Fifth clean - styles and using common TLMM schema: *THIS PATCHSET*
Blanket:
Acked-by: Linus Walleij <[email protected]>
Please send me pull requests for any parts that need to go into
the pinctrl tree.
Yours,
Linus Walleij
On 17/10/2022 05:24, Linus Walleij wrote:
> On Thu, Oct 6, 2022 at 4:06 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>
>> Patches are organized not by file, but rather type of change
>> 1. First patches is for common TLMM schema and dropping unneeded refs.
>> 2. Last patches are pure cleanups without functional impact.
>>
>> Overview
>> ========
>> This is the *fifth* patchset around Qualcomm pinctrl in recent days:
>> 1. First round of TLMM fixes: merged
>> 2. LPASS fixes:
>> https://lore.kernel.org/linux-devicetree/[email protected]/
>> 3. ARMv7 TLMM fixes:
>> https://lore.kernel.org/linux-devicetree/[email protected]/
>> 4. ARMv8 remaining TLMM fixes:
>> https://lore.kernel.org/linux-devicetree/[email protected]/
>> 5. Fifth clean - styles and using common TLMM schema: *THIS PATCHSET*
>
> Blanket:
> Acked-by: Linus Walleij <[email protected]>
>
> Please send me pull requests for any parts that need to go into
> the pinctrl tree.
Will do.
Best regards,
Krzysztof