2022-10-06 15:29:09

by Chukun Pan

[permalink] [raw]
Subject: [PATCH v2 0/2] arm64: dts: rockchip: enable pcie3 support for rock-3a

Changes from v2:
* Removed changes to pcie2x1 node.
* Collected acked-by and tested-by.

Chukun Pan (2):
arm64: dts: rockchip: Add regulator suffix to rock-3a
arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a

.../boot/dts/rockchip/rk3568-rock-3a.dts | 58 ++++++++++++++++---
1 file changed, 51 insertions(+), 7 deletions(-)

--
2.25.1


2022-10-06 15:42:05

by Chukun Pan

[permalink] [raw]
Subject: [PATCH v2 2/2] arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a

Add Nodes to Radxa ROCK3 Model A board to support PCIe v3.

Tested-by: Anand Moon <[email protected]>
Signed-off-by: Chukun Pan <[email protected]>
---
.../boot/dts/rockchip/rk3568-rock-3a.dts | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index 8adf672709e8..c1fa917083ba 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -67,6 +67,37 @@ vcc12v_dcin: vcc12v-dcin-regulator {
regulator-boot-on;
};

+ pcie30_avdd0v9: pcie30-avdd0v9-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "pcie30_avdd0v9";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+ vin-supply = <&vcc3v3_sys>;
+ };
+
+ pcie30_avdd1v8: pcie30-avdd1v8-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "pcie30_avdd1v8";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vcc3v3_sys>;
+ };
+
+ /* pi6c pcie clock generator */
+ vcc3v3_pi6c_03: vcc3v3-pi6c-03-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc3v3_pi6c_03";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
vcc3v3_pcie: vcc3v3-pcie-regulator {
compatible = "regulator-fixed";
enable-active-high;
@@ -546,6 +577,19 @@ &pcie2x1 {
status = "okay";
};

+&pcie30phy {
+ phy-supply = <&vcc3v3_pi6c_03>;
+ status = "okay";
+};
+
+&pcie3x2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie30x2m1_pins>;
+ reset-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
&pinctrl {
cam {
vcc_cam_en: vcc_cam_en {
--
2.25.1

2022-10-06 16:07:55

by Chukun Pan

[permalink] [raw]
Subject: [PATCH v2 1/2] arm64: dts: rockchip: Add regulator suffix to rock-3a

Add -regulator suffix to regulator names on Radxa ROCK3 Model A
board. This makes the naming more consistent.

Signed-off-by: Chukun Pan <[email protected]>
Acked-by: Michael Riesch <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index fb87a168fe96..8adf672709e8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -60,7 +60,7 @@ simple-audio-card,codec {
};
};

- vcc12v_dcin: vcc12v-dcin {
+ vcc12v_dcin: vcc12v-dcin-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc12v_dcin";
regulator-always-on;
@@ -79,7 +79,7 @@ vcc3v3_pcie: vcc3v3-pcie-regulator {
vin-supply = <&vcc5v0_sys>;
};

- vcc3v3_sys: vcc3v3-sys {
+ vcc3v3_sys: vcc3v3-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
regulator-always-on;
@@ -89,7 +89,7 @@ vcc3v3_sys: vcc3v3-sys {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_sys: vcc5v0-sys {
+ vcc5v0_sys: vcc5v0-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_sys";
regulator-always-on;
@@ -99,7 +99,7 @@ vcc5v0_sys: vcc5v0-sys {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_usb: vcc5v0-usb {
+ vcc5v0_usb: vcc5v0-usb-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_usb";
regulator-always-on;
@@ -109,7 +109,7 @@ vcc5v0_usb: vcc5v0-usb {
vin-supply = <&vcc12v_dcin>;
};

- vcc5v0_usb_host: vcc5v0-usb-host {
+ vcc5v0_usb_host: vcc5v0-usb-host-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
@@ -144,7 +144,7 @@ vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
vin-supply = <&vcc5v0_usb>;
};

- vcc_cam: vcc-cam {
+ vcc_cam: vcc-cam-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
@@ -160,7 +160,7 @@ regulator-state-mem {
};
};

- vcc_mipi: vcc-mipi {
+ vcc_mipi: vcc-mipi-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
--
2.25.1

2022-10-17 13:20:13

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] arm64: dts: rockchip: enable pcie3 support for rock-3a

On Thu, 6 Oct 2022 23:25:22 +0800, Chukun Pan wrote:
> Changes from v2:
> * Removed changes to pcie2x1 node.
> * Collected acked-by and tested-by.
>
> Chukun Pan (2):
> arm64: dts: rockchip: Add regulator suffix to rock-3a
> arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a
>
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: Add regulator suffix to rock-3a
commit: 49665ab0ed5eed4fa7b8a6b236ff2df681c89673
[2/2] arm64: dts: rockchip: Add PCIe v3 nodes to rock-3a
commit: 0522cd8112204d124d714eee7e9f0cac6de999d9

Best regards,
--
Heiko Stuebner <[email protected]>