2022-10-08 07:44:57

by Ke Sun

Subject: [RESEND] rtc: rv3028: Fix codestyle errors

Compiler warnings：

drivers/rtc/rtc-rv3028.c: In function 'rv3028_param_set':
drivers/rtc/rtc-rv3028.c:559:20: warning: statement will never be executed [-Wswitch-unreachable]
559 | u8 mode;
| ^~~~
drivers/rtc/rtc-rv3028.c: In function 'rv3028_param_get':
drivers/rtc/rtc-rv3028.c:526:21: warning: statement will never be executed [-Wswitch-unreachable]
526 | u32 value;
| ^~~~~

Fix it by moving the variable declaration to the beginning of the function.

Cc: Alessandro Zummo <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: [email protected]
Cc: [email protected]
Reported-by: k2ci <[email protected]>
Signed-off-by: Ke Sun <[email protected]>
---
drivers/rtc/rtc-rv3028.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
index cdc623b3e365b..dd170e3efd83e 100644
--- a/drivers/rtc/rtc-rv3028.c
+++ b/drivers/rtc/rtc-rv3028.c
@@ -521,10 +521,9 @@ static int rv3028_param_get(struct device *dev, struct rtc_param *param)
{
struct rv3028_data *rv3028 = dev_get_drvdata(dev);
int ret;
+ u32 value;

switch(param->param) {
- u32 value;
-
case RTC_PARAM_BACKUP_SWITCH_MODE:
ret = regmap_read(rv3028->regmap, RV3028_BACKUP, &value);
if (ret < 0)
@@ -554,9 +553,9 @@ static int rv3028_param_get(struct device *dev, struct rtc_param *param)
static int rv3028_param_set(struct device *dev, struct rtc_param *param)
{
struct rv3028_data *rv3028 = dev_get_drvdata(dev);
+ u8 mode;

switch(param->param) {
- u8 mode;
case RTC_PARAM_BACKUP_SWITCH_MODE:
switch (param->uvalue) {
case RTC_BSM_DISABLED:
--
2.25.1

2022-10-13 22:33:34

by Alexandre Belloni

Subject: Re: [RESEND] rtc: rv3028: Fix codestyle errors

On Sat, 8 Oct 2022 15:13:21 +0800, Ke Sun wrote:
> Compiler warnings：
>
> drivers/rtc/rtc-rv3028.c: In function 'rv3028_param_set':
> drivers/rtc/rtc-rv3028.c:559:20: warning: statement will never be executed [-Wswitch-unreachable]
> 559 | u8 mode;
> | ^~~~
> drivers/rtc/rtc-rv3028.c: In function 'rv3028_param_get':
> drivers/rtc/rtc-rv3028.c:526:21: warning: statement will never be executed [-Wswitch-unreachable]
> 526 | u32 value;
> | ^~~~~
>
> [...]

Applied, thanks!

[1/1] rtc: rv3028: Fix codestyle errors
commit: e5f12a398371280649ccc9d6eb0b97fd42a5df98

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com