2022-10-08 08:51:06

by Li zeming

[permalink] [raw]
Subject: [PATCH] hv: Remove unnecessary (void*) conversions

addrp is a void pointer and does not require a cast type.

Signed-off-by: Li zeming <[email protected]>
---
tools/hv/hv_kvp_daemon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 1e6fd6ca513b..445abb53bf0d 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -772,11 +772,11 @@ static int kvp_process_ip_address(void *addrp,
const char *str;

if (family == AF_INET) {
- addr = (struct sockaddr_in *)addrp;
+ addr = addrp;
str = inet_ntop(family, &addr->sin_addr, tmp, 50);
addr_length = INET_ADDRSTRLEN;
} else {
- addr6 = (struct sockaddr_in6 *)addrp;
+ addr6 = addrp;
str = inet_ntop(family, &addr6->sin6_addr.s6_addr, tmp, 50);
addr_length = INET6_ADDRSTRLEN;
}
--
2.18.2


2022-10-26 15:44:26

by Wei Liu

[permalink] [raw]
Subject: Re: [PATCH] hv: Remove unnecessary (void*) conversions

On Sat, Oct 08, 2022 at 04:32:06PM +0800, Li zeming wrote:
> addrp is a void pointer and does not require a cast type.
>
> Signed-off-by: Li zeming <[email protected]>

This has already been changed. Thanks for the patch anyway.