2022-10-08 17:48:56

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v3 0/2] remoteproc: qcom: Add support for MSM8953 ADSP

This patch series adds support for the ADSP PIL as found on the MSM8953
platform. It is a subset of a previous patch series.

Changes since v2:
* Made ordering of compatible strings lexical in doc patch

Link to v1: https://lkml.org/lkml/2022/10/6/18

Sireesh Kodali (2):
remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
2 files changed, 6 insertions(+)

--
2.37.3


2022-10-08 17:50:31

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v3 2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

Add support for booting the Audio DSP on the MSM8953 platform. This is
used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the
configuration is the same on all SoCs, a single compatible string is
used.

Signed-off-by: Sireesh Kodali <[email protected]>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 3072af5f9d79..9731ccb336f4 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -17,6 +17,7 @@ properties:
compatible:
enum:
- qcom,msm8226-adsp-pil
+ - qcom,msm8953-adsp-pil
- qcom,msm8974-adsp-pil
- qcom,msm8996-adsp-pil
- qcom,msm8996-slpi-pil
@@ -178,6 +179,7 @@ allOf:
contains:
enum:
- qcom,msm8226-adsp-pil
+ - qcom,msm8953-adsp-pil
- qcom,msm8974-adsp-pil
- qcom,msm8996-adsp-pil
- qcom,msm8996-slpi-pil
@@ -297,6 +299,7 @@ allOf:
contains:
enum:
- qcom,msm8226-adsp-pil
+ - qcom,msm8953-adsp-pil
- qcom,msm8974-adsp-pil
- qcom,msm8996-adsp-pil
- qcom,msm8996-slpi-pil
@@ -369,6 +372,7 @@ allOf:
contains:
enum:
- qcom,msm8226-adsp-pil
+ - qcom,msm8953-adsp-pil
- qcom,msm8996-adsp-pil
- qcom,msm8998-adsp-pas
- qcom,sm8150-adsp-pas
@@ -558,6 +562,7 @@ allOf:
contains:
enum:
- qcom,msm8226-adsp-pil
+ - qcom,msm8953-adsp-pil
- qcom,msm8974-adsp-pil
- qcom,msm8996-adsp-pil
- qcom,msm8996-slpi-pil
--
2.37.3

2022-10-08 17:57:18

by Sireesh Kodali

[permalink] [raw]
Subject: [PATCH v3 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

Add support for the Audio DSP PIL found on the Qualcomm MSM8953
platform. The same configuration is used on all SoCs based on the
MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).

Signed-off-by: Sireesh Kodali <[email protected]>
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 6afd0941e552..70b3a37c4814 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
{ .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
+ { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
{ .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource},
{ .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init},
--
2.37.3

2022-10-10 11:17:07

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

On 08/10/2022 13:46, Sireesh Kodali wrote:
> Add support for the Audio DSP PIL found on the Qualcomm MSM8953
> platform. The same configuration is used on all SoCs based on the
> MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
>
> Signed-off-by: Sireesh Kodali <[email protected]>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 6afd0941e552..70b3a37c4814 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
> { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
> { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
> + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},

This one also in alphanumeric order, by compatible.


Best regards,
Krzysztof

2022-10-10 11:51:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] dt-bindings: remoteproc: qcom: adsp: Add ADSP on MSM8953

On 08/10/2022 13:46, Sireesh Kodali wrote:
> Add support for booting the Audio DSP on the MSM8953 platform. This is
> used by SoCs like SDM450, SDM625, SDM626, APQ8053, etc. Since the
> configuration is the same on all SoCs, a single compatible string is
> used.
>
> Signed-off-by: Sireesh Kodali <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-10-12 18:53:55

by Sireesh Kodali

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support

On Mon Oct 10, 2022 at 4:22 PM IST, Krzysztof Kozlowski wrote:
> On 08/10/2022 13:46, Sireesh Kodali wrote:
> > Add support for the Audio DSP PIL found on the Qualcomm MSM8953
> > platform. The same configuration is used on all SoCs based on the
> > MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
> >
> > Signed-off-by: Sireesh Kodali <[email protected]>
> > ---
> > drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> > index 6afd0941e552..70b3a37c4814 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -950,6 +950,7 @@ static const struct of_device_id adsp_of_match[] = {
> > { .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
> > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
> > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
> > + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
>
> This one also in alphanumeric order, by compatible.

Will be fixed in the next iteration

Regards,
Sireesh Kodali
>
>
> Best regards,
> Krzysztof