From: Jiangshan Yi <[email protected]>
Fix spelling typo in comment.
K2ci (Kylin Continuous Integration) is a code pre-verification tool
independently developed by KylinSoft, which is used for ensuring the
code quality of code submission. K2ci includes the comment check tool
notes_check.
This spelling typo was found using notes_check tool.
Reported-by: k2ci <[email protected]>
Signed-off-by: Jiangshan Yi <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index d3f10a3cf972..a421c430164a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
return res;
}
-/* dont call R/W in this function, beucase SDIO interrupt have claim host */
+/* don't call R/W in this function, because SDIO interrupt have claim host */
/* or deadlock will happen and cause special-systemserver-died in android */
u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
{
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 06e727ce9cc2..71800917d132 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -277,7 +277,7 @@ bool bPseudoTest)
return bResult;
}
-/* 11/16/2008 MH Write one byte to reald Efuse. */
+/* 11/16/2008 MH Write one byte to real Efuse. */
u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest)
{
u8 tmpidx = 0;
diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging/rtl8723bs/include/sta_info.h
index 69c377eeeaf0..1c3f83867cb0 100644
--- a/drivers/staging/rtl8723bs/include/sta_info.h
+++ b/drivers/staging/rtl8723bs/include/sta_info.h
@@ -190,7 +190,7 @@ struct sta_info {
/* ODM_STA_INFO_T */
/* ================ODM Relative Info ======================= */
- /* Please be care, dont declare too much structure here. It will cost memory * STA support num. */
+ /* Please be care, don't declare too much structure here. It will cost memory * STA support num. */
/* */
/* */
/* 2011/10/20 MH Add for ODM STA info. */
--
2.25.1
No virus found
Checked by Hillstone Network AntiVirus
On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <[email protected]>
Then why is this being sent from a 163.com address?
What is wrong with using your real mail server?
>
> Fix spelling typo in comment.
>
> K2ci (Kylin Continuous Integration) is a code pre-verification tool
> independently developed by KylinSoft, which is used for ensuring the
> code quality of code submission. K2ci includes the comment check tool
> notes_check.
>
> This spelling typo was found using notes_check tool.
>
> Reported-by: k2ci <[email protected]>
> Signed-off-by: Jiangshan Yi <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
> drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index d3f10a3cf972..a421c430164a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
> return res;
> }
>
> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
> +/* don't call R/W in this function, because SDIO interrupt have claim host */
That is not a spelling fix, but rather a "punctuation" fix if you want
to be picky :)
> /* or deadlock will happen and cause special-systemserver-died in android */
> u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
> {
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 06e727ce9cc2..71800917d132 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -277,7 +277,7 @@ bool bPseudoTest)
> return bResult;
> }
>
> -/* 11/16/2008 MH Write one byte to reald Efuse. */
> +/* 11/16/2008 MH Write one byte to real Efuse. */
The date should just be removed entirely, right?
> u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest)
> {
> u8 tmpidx = 0;
> diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging/rtl8723bs/include/sta_info.h
> index 69c377eeeaf0..1c3f83867cb0 100644
> --- a/drivers/staging/rtl8723bs/include/sta_info.h
> +++ b/drivers/staging/rtl8723bs/include/sta_info.h
> @@ -190,7 +190,7 @@ struct sta_info {
>
> /* ODM_STA_INFO_T */
> /* ================ODM Relative Info ======================= */
> - /* Please be care, dont declare too much structure here. It will cost memory * STA support num. */
> + /* Please be care, don't declare too much structure here. It will cost memory * STA support num. */
Same here.
thanks,
greg k-h
At 2022-10-10 02:21:46, "Greg KH" <[email protected]> wrote:
>On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
>> From: Jiangshan Yi <[email protected]>
>
>Then why is this being sent from a 163.com address?
>
>What is wrong with using your real mail server?
There is a problem with the company's mailbox, and sometimes I can't receive emails. So I temporarily use my personal mailbox to send patches, so that I can receive feedback from the community in a timely manner.
>> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
>> return res;
>> }
>>
>> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
>> +/* don't call R/W in this function, because SDIO interrupt have claim host */
>
>That is not a spelling fix, but rather a "punctuation" fix if you want
>to be picky :)
The patch does s/beucase/because/ and s/dont/don't/.
Follow Documentation/process/coding-style.rst??something write like this:
---------------------------------------
Kernel developers like to be seen as literate. Do mind the spelling
of kernel messages to make a good impression. Do not use incorrect
contractions like ``dont``; use ``do not`` or ``don't`` instead. Make the
messages concise, clear, and unambiguous.
---------------------------------------
So does the comment.
>> /* or deadlock will happen and cause special-systemserver-died in android */
>> u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
>> {
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> index 06e727ce9cc2..71800917d132 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
>> @@ -277,7 +277,7 @@ bool bPseudoTest)
>> return bResult;
>> }
>>
>> -/* 11/16/2008 MH Write one byte to reald Efuse. */
>> +/* 11/16/2008 MH Write one byte to real Efuse. */
>
>The date should just be removed entirely, right?
You're right.
thanks,
Jiangshan Yi
On Mon, Oct 10, 2022 at 11:07:31AM +0800, Yi Jiangshan wrote:
>
> At 2022-10-10 02:21:46, "Greg KH" <[email protected]> wrote:
> >On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
> >> From: Jiangshan Yi <[email protected]>
> >
> >Then why is this being sent from a 163.com address?
> >
>
> >What is wrong with using your real mail server?
>
>
> There is a problem with the company's mailbox, and sometimes I can't receive emails. So I temporarily use my personal mailbox to send patches, so that I can receive feedback from the community in a timely manner.
But how do I know that this is a valid company email address at all?
It's not authenticated as such, so many companies do not like people
faking their address.
Please send from your company address and you can always cc: the 163.com
one, right?
thanks,
greg k-h