2022-10-09 10:17:52

by Yi Jiangshan

[permalink] [raw]
Subject: [PATCH] staging: sm750fb: fix spelling typo in comment

From: Jiangshan Yi <[email protected]>

Fix spelling typo in comment.

K2CI (Kylin Kernel Continuous Integration) is a code pre-verification tool
independently developed by KylinSoft, which is used for ensuring the
code quality of code submission. K2CI includes the comment check tool
notes_check.

This spelling typo was found using notes_check tool.

Reported-by: k2ci <[email protected]>
Signed-off-by: Jiangshan Yi <[email protected]>
---
drivers/staging/sm750fb/ddk750_dvi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h
index c2518b73bdbd..afdfdb17ffce 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.h
+++ b/drivers/staging/sm750fb/ddk750_dvi.h
@@ -2,7 +2,7 @@
#ifndef DDK750_DVI_H__
#define DDK750_DVI_H__

-/* dvi chip stuffs structros */
+/* dvi chip stuffs structures */

typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
unsigned char bus_select,
--
2.25.1


No virus found
Checked by Hillstone Network AntiVirus


2022-10-09 14:35:59

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] staging: sm750fb: fix spelling typo in comment

On Sun, Oct 09, 2022 at 05:48:09PM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <[email protected]>
>
> Fix spelling typo in comment.
>

What comment are you trying to do this typofix? Even seeing the diff
below, I can't figure out that due to insufficient context.

> K2CI (Kylin Kernel Continuous Integration) is a code pre-verification tool
> independently developed by KylinSoft, which is used for ensuring the
> code quality of code submission. K2CI includes the comment check tool
> notes_check.
>
> This spelling typo was found using notes_check tool.
>

For CI bot like this, I'd like to see publicly-accessible reports (like
build status), just like what kernel test robot (aka LKP aka 01-DAY CI)
does (try searching LKML for recent report by it). Don't forget to add
Link: tag to the report.

> Reported-by: k2ci <[email protected]>
> Signed-off-by: Jiangshan Yi <[email protected]>
> ---
> drivers/staging/sm750fb/ddk750_dvi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h
> index c2518b73bdbd..afdfdb17ffce 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.h
> +++ b/drivers/staging/sm750fb/ddk750_dvi.h
> @@ -2,7 +2,7 @@
> #ifndef DDK750_DVI_H__
> #define DDK750_DVI_H__
>
> -/* dvi chip stuffs structros */
> +/* dvi chip stuffs structures */
>
> typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select,
> unsigned char bus_select,

Are the structures really plural (many instances of the struct)?

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.62 kB)
signature.asc (235.00 B)
Download all attachments

2022-10-09 18:30:55

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: sm750fb: fix spelling typo in comment

On Sun, Oct 09, 2022 at 05:48:09PM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <[email protected]>

Again, why 163.com?

thanks,

greg k-h

2022-10-10 03:10:23

by Yi Jiangshan

[permalink] [raw]
Subject: Re:Re: [PATCH] staging: sm750fb: fix spelling typo in comment


At 2022-10-10 02:22:40, "Greg KH" <[email protected]> wrote:
>On Sun, Oct 09, 2022 at 05:48:09PM +0800, Jiangshan Yi wrote:
>> From: Jiangshan Yi <[email protected]>
>
>Again, why 163.com?
>



There is a problem with the company's mailbox, and sometimes I can't receive emails. So I temporarily use my personal email to send patches, so that I can receive feedback from the community in a timely manner.


thanks??


Jiangshan Yi