Description of io_stop_wc(), which added by commit d5624bb29f49
("asm-generic: introduce io_stop_wc() and add implementation for
ARM64"), have unclosed parenthesis. This commit closes it.
Fixes: d5624bb29f49 ("asm-generic: introduce io_stop_wc() and add implementation for ARM64")
Signed-off-by: SeongJae Park <[email protected]>
---
Documentation/memory-barriers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index 06f80e3785c5..cc621decd943 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -1966,7 +1966,7 @@ There are some more advanced barrier functions:
(*) io_stop_wc();
For memory accesses with write-combining attributes (e.g. those returned
- by ioremap_wc(), the CPU may wait for prior accesses to be merged with
+ by ioremap_wc()), the CPU may wait for prior accesses to be merged with
subsequent ones. io_stop_wc() can be used to prevent the merging of
write-combining memory accesses before this macro with those after it when
such wait has performance implications.
--
2.17.1
On Sat, Oct 08, 2022 at 10:49:25AM -0700, SeongJae Park wrote:
> Description of io_stop_wc(), which added by commit d5624bb29f49
> ("asm-generic: introduce io_stop_wc() and add implementation for
> ARM64"), have unclosed parenthesis. This commit closes it.
>
> Fixes: d5624bb29f49 ("asm-generic: introduce io_stop_wc() and add implementation for ARM64")
> Signed-off-by: SeongJae Park <[email protected]>
I have pulled this in, good eyes, and thank you!
On the other three, we have traditionally asked for an ack from a
Korean speaker. Do we still feel the need to do this?
Thanx, Paul
> ---
> Documentation/memory-barriers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index 06f80e3785c5..cc621decd943 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -1966,7 +1966,7 @@ There are some more advanced barrier functions:
> (*) io_stop_wc();
>
> For memory accesses with write-combining attributes (e.g. those returned
> - by ioremap_wc(), the CPU may wait for prior accesses to be merged with
> + by ioremap_wc()), the CPU may wait for prior accesses to be merged with
> subsequent ones. io_stop_wc() can be used to prevent the merging of
> write-combining memory accesses before this macro with those after it when
> such wait has performance implications.
> --
> 2.17.1
>
Hi Paul,
On Sun, 9 Oct 2022 04:10:00 -0700 "Paul E. McKenney" <[email protected]> wrote:
> On Sat, Oct 08, 2022 at 10:49:25AM -0700, SeongJae Park wrote:
> > Description of io_stop_wc(), which added by commit d5624bb29f49
> > ("asm-generic: introduce io_stop_wc() and add implementation for
> > ARM64"), have unclosed parenthesis. This commit closes it.
> >
> > Fixes: d5624bb29f49 ("asm-generic: introduce io_stop_wc() and add implementation for ARM64")
> > Signed-off-by: SeongJae Park <[email protected]>
>
> I have pulled this in, good eyes, and thank you!
Thank you for quick reply :)
>
> On the other three, we have traditionally asked for an ack from a
> Korean speaker. Do we still feel the need to do this?
I have asked review of the patches to my friend. I'm unsure if my friend could
do that in a timely manner, as my friend could also be busy. Let's wait and
see.
IMHO, such review is not essential for this kind of incremental document
updates, as I'd prefer making the doc up-to-date even if it contains some
trivial errors, as long as the history is well manged and therefore such errors
could be fixed later with good explanations.
Thanks,
SJ
[...]
On Sun, 9 Oct 2022 18:37:23 +0000 SeongJae Park <[email protected]> wrote:
> Hi Paul,
>
> On Sun, 9 Oct 2022 04:10:00 -0700 "Paul E. McKenney" <[email protected]> wrote:
>
> > On Sat, Oct 08, 2022 at 10:49:25AM -0700, SeongJae Park wrote:
> > > Description of io_stop_wc(), which added by commit d5624bb29f49
> > > ("asm-generic: introduce io_stop_wc() and add implementation for
> > > ARM64"), have unclosed parenthesis. This commit closes it.
> > >
> > > Fixes: d5624bb29f49 ("asm-generic: introduce io_stop_wc() and add implementation for ARM64")
> > > Signed-off-by: SeongJae Park <[email protected]>
> >
> > I have pulled this in, good eyes, and thank you!
>
> Thank you for quick reply :)
>
> >
> > On the other three, we have traditionally asked for an ack from a
> > Korean speaker. Do we still feel the need to do this?
>
> I have asked review of the patches to my friend. I'm unsure if my friend could
> do that in a timely manner, as my friend could also be busy. Let's wait and
> see.
Thankfully, my friend gave me a feedback for improving the patch. He has some
mailing tools issue, so I'm saying this instead. I will post next version of
the translations patches soon.
Thanks,
SJ
>
> IMHO, such review is not essential for this kind of incremental document
> updates, as I'd prefer making the doc up-to-date even if it contains some
> trivial errors, as long as the history is well manged and therefore such errors
> could be fixed later with good explanations.
>
>
> Thanks,
> SJ
>
> [...]
>