2022-10-09 18:20:31

by Nam Cao

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8192e: remove necessary braces for single statement blocks

On Sun, Oct 09, 2022 at 10:26:31PM +0800, Rui Li wrote:
> This commit cleans up checkpatch warning as follows:
> braces {} are not necessary for single statement blocks
>
> Signed-off-by: Rui Li <[email protected]>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 +++------
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ++++--------
> 3 files changed, 8 insertions(+), 16 deletions(-)

Greg expects a change log describing what has changed compared to the
last version. You should send a v3 with a changelog.

Additionally, did you mean "unnecessary" in the title?

Best regards,
Nam