There is no "bias-no-pull" property. Assume intentions were disabling
bias.
Fixes: b190fb010664 ("arm64: dts: qcom: sdm630: Add sdm630 dts file")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Douglas Anderson <[email protected]>
---
Changes since v1:
1. Drop cc-stable.
2. Add tags.
Not tested on hardware.
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index b51b85f583e5..e119060ac56c 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -779,7 +779,7 @@ rx-cts-rts {
pins = "gpio17", "gpio18", "gpio19";
function = "gpio";
drive-strength = <2>;
- bias-no-pull;
+ bias-disable;
};
};
--
2.34.1
The pin configuration (done with generic pin controller helpers and
as expressed by bindings) requires children nodes with either:
1. "pins" property and the actual configuration,
2. another set of nodes with above point.
The qup_i2c12_default pin configuration used second method - with a
"pinmux" child.
Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Tested-by: Steev Klimaszewski <[email protected]>
---
Changes since v1:
1. Add tags.
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index be59a8ba9c1f..74f43da51fa5 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -487,8 +487,10 @@ pinconf {
};
&qup_i2c12_default {
- drive-strength = <2>;
- bias-disable;
+ pinmux {
+ drive-strength = <2>;
+ bias-disable;
+ };
};
&qup_uart6_default {
--
2.34.1
On Mon, 10 Oct 2022 07:44:12 -0400, Krzysztof Kozlowski wrote:
> There is no "bias-no-pull" property. Assume intentions were disabling
> bias.
>
>
Applied, thanks!
[1/6] arm64: dts: qcom: sdm630: fix UART1 pin bias
commit: 780f836fe071a9e8703fe6a05ae00129acf83391
[2/6] arm64: dts: qcom: sdm845-db845c: correct SPI2 pins drive strength
commit: 9905370560d9c29adc15f4937c5a0c0dac05f0b4
[3/6] arm64: dts: qcom: sdm845-cheza: fix AP suspend pin bias
commit: 9bce41fab14da8f21027dc9847535ef5e22cbe8b
[4/6] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength
commit: fd49776d8f458bba5499384131eddc0b8bcaf50c
[5/6] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength
commit: 3638ea010c37e1e6d93474c4b3368f403600413f
[6/6] arm64: dts: qcom: sdm845-xiaomi-polaris: fix codec pin conf name
commit: 58c4a0b6f4bdf8c3c2b4aad7f980e4019cc0fc83
Best regards,
--
Bjorn Andersson <[email protected]>