2022-10-12 10:57:01

by Li zeming

Subject: [PATCH] fs: udf: Optimize udf_free_in_core_inode and udf_find_fileset function

These two functions perform the following optimizations.
1. Delete the type cast of foo pointer. Void * does not need to convert
the type.
2. Delete the initialization assignment of bh variable, which is
assigned first.

Signed-off-by: Li zeming <[email protected]>
---
fs/udf/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/udf/super.c b/fs/udf/super.c
index 4042d9739fb7..06eda8177b5f 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -162,7 +162,7 @@ static void udf_free_in_core_inode(struct inode *inode)

static void init_once(void *foo)
{
- struct udf_inode_info *ei = (struct udf_inode_info *)foo;
+ struct udf_inode_info *ei = foo;

ei->i_data = NULL;
inode_init_once(&ei->vfs_inode);
@@ -820,7 +820,7 @@ static int udf_find_fileset(struct super_block *sb,
struct kernel_lb_addr *fileset,
struct kernel_lb_addr *root)
{
- struct buffer_head *bh = NULL;
+ struct buffer_head *bh;
uint16_t ident;
int ret;

--
2.18.2

2022-10-12 16:47:41

by Jan Kara

Subject: Re: [PATCH] fs: udf: Optimize udf_free_in_core_inode and udf_find_fileset function

On Wed 12-10-22 18:42:35, Li zeming wrote:
> These two functions perform the following optimizations.
> 1. Delete the type cast of foo pointer. Void * does not need to convert
> the type.
> 2. Delete the initialization assignment of bh variable, which is
> assigned first.
>
> Signed-off-by: Li zeming <[email protected]>

Thanks for the patch. It looks good, I'll queue it into my tree once the
merge window closes.

Honza

> ---
> fs/udf/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 4042d9739fb7..06eda8177b5f 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -162,7 +162,7 @@ static void udf_free_in_core_inode(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct udf_inode_info *ei = (struct udf_inode_info *)foo;
> + struct udf_inode_info *ei = foo;
>
> ei->i_data = NULL;
> inode_init_once(&ei->vfs_inode);
> @@ -820,7 +820,7 @@ static int udf_find_fileset(struct super_block *sb,
> struct kernel_lb_addr *fileset,
> struct kernel_lb_addr *root)
> {
> - struct buffer_head *bh = NULL;
> + struct buffer_head *bh;
> uint16_t ident;
> int ret;
>
> --
> 2.18.2
>
--
Jan Kara <[email protected]>
SUSE Labs, CR