2022-10-12 20:27:00

by Job Noorman

Subject: [PATCH v2 1/3] dt-bindings: touchscreen: add Himax hx83112b bindings

This patch adds device tree bindings for Himax 83112b touchscreen
devices.

Signed-off-by: Job Noorman <[email protected]>
---
.../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++
MAINTAINERS | 6 ++
2 files changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml

diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
new file mode 100644
index 000000000000..c10c82415401
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/touchscreen/himax,hx83112b.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax hx83112b touchscreen controller bindings
+
+maintainers:
+ - Job Noorman <[email protected]>
+
+allOf:
+ - $ref: touchscreen.yaml#
+
+properties:
+ compatible:
+ enum:
+ - himax,hx83112b
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ reset-gpios:
+ maxItems: 1
+
+ touchscreen-inverted-x: true
+ touchscreen-inverted-y: true
+ touchscreen-size-x: true
+ touchscreen-size-y: true
+ touchscreen-swapped-x-y: true
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - reset-gpios
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ touchscreen@48 {
+ compatible = "himax,hx83112b";
+ reg = <0x48>;
+ interrupt-parent = <&tlmm>;
+ interrupts = <65 IRQ_TYPE_LEVEL_LOW>;
+ touchscreen-size-x = <1080>;
+ touchscreen-size-y = <2160>;
+ reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 9ddcc242081c..2418bffe9187 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9094,6 +9094,12 @@ W: http://www.highpoint-tech.com
F: Documentation/scsi/hptiop.rst
F: drivers/scsi/hptiop.c

+HIMAX HX83112B TOUCHSCREEN SUPPORT
+M: Job Noorman <[email protected]>
+L: [email protected]
+S: Maintained
+F: Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
+
HIPPI
M: Jes Sorensen <[email protected]>
L: [email protected]
--
2.38.0

2022-10-13 21:09:35

by Rob Herring (Arm)

Subject: Re: [PATCH v2 1/3] dt-bindings: touchscreen: add Himax hx83112b bindings

On Wed, 12 Oct 2022 20:24:06 +0000, Job Noorman wrote:
> This patch adds device tree bindings for Himax 83112b touchscreen
> devices.
>
> Signed-off-by: Job Noorman <[email protected]>
> ---
> .../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2022-10-14 08:16:06

by Job Noorman

Subject: Re: [PATCH v2 1/3] dt-bindings: touchscreen: add Himax hx83112b bindings

Hi Rob,

Thanks for you review!

On Thu Oct 13, 2022 at 10:25 PM CEST, Rob Herring wrote:
> On Wed, 12 Oct 2022 20:24:06 +0000, Job Noorman wrote:
> > This patch adds device tree bindings for Himax 83112b touchscreen
> > devices.
> >
> > Signed-off-by: Job Noorman <[email protected]>
> > ---
> > .../input/touchscreen/himax,hx83112b.yaml | 61 +++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 67 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> >
>
> Reviewed-by: Rob Herring <[email protected]>

The next version of this patch will make the properties touchscreen-size-{x,y}
required. Can I still attach your "Reviewed-by" tag to this updated patch or
would you like to have a look at it first?

Kind regards,
Job