Hi,
Those patches have been in the downstream RaspberryPi tree for a while and help
to support more DPI displays.
Let me know what you think,
Maxime
To: Emma Anholt <[email protected]>
To: Maxime Ripard <[email protected]>
To: David Airlie <[email protected]>
To: Daniel Vetter <[email protected]>
To: Eric Anholt <[email protected]>
To: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Chris Morgan <[email protected]>
Cc: Joerg Quinten <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Dave Stevenson <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
---
Chris Morgan (2):
media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI
drm/vc4: dpi: Support RGB565 format
Dave Stevenson (2):
drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24.
drm/vc4: dpi: Fix format mapping for RGB565
Joerg Quinten (3):
media: uapi: add MEDIA_BUS_FMT_BGR666_1X18
media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI
drm/vc4: dpi: Support BGR666 formats
drivers/gpu/drm/vc4/vc4_dpi.c | 16 +++++++++++++---
include/uapi/linux/media-bus-format.h | 5 ++++-
2 files changed, 17 insertions(+), 4 deletions(-)
---
base-commit: c9b48b91e2fbb74fb981aa616a6ef3c78194077f
change-id: 20221013-rpi-dpi-improvements-c3d755531c39
Best regards,
--
Maxime Ripard <[email protected]>
From: Joerg Quinten <[email protected]>
Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the
RaspberryPi.
Signed-off-by: Joerg Quinten <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
---
include/uapi/linux/media-bus-format.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index b0a945eb7040..2ee0b38c0a71 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -34,7 +34,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x1023 */
+/* RGB - next is 0x1024 */
#define MEDIA_BUS_FMT_RGB444_1X12 0x1016
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
@@ -46,6 +46,7 @@
#define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006
#define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
#define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
+#define MEDIA_BUS_FMT_BGR666_1X18 0x1023
#define MEDIA_BUS_FMT_RGB666_1X18 0x1009
#define MEDIA_BUS_FMT_RBG888_1X24 0x100e
#define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
--
b4 0.11.0-dev-7da52
Hi Maxime,
Thank you for the patch.
On Thu, Oct 13, 2022 at 11:56:46AM +0200, Maxime Ripard wrote:
> From: Joerg Quinten <[email protected]>
>
> Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the
> RaspberryPi.
>
> Signed-off-by: Joerg Quinten <[email protected]>
> Signed-off-by: Maxime Ripard <[email protected]>
> ---
> include/uapi/linux/media-bus-format.h | 3 ++-
New formats need documentation in
Documentation/userspace-api/media/v4l/subdev-formats.rst. Same for
patches 1/7 and 3/7.
Apart from that, the patch looks good to me.
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index b0a945eb7040..2ee0b38c0a71 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x1023 */
> +/* RGB - next is 0x1024 */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -46,6 +46,7 @@
> #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006
> #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
> #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
> +#define MEDIA_BUS_FMT_BGR666_1X18 0x1023
> #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
> #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
> #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
>
--
Regards,
Laurent Pinchart