2022-10-14 08:46:38

by Marcus Folkesson

Subject: [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate

GENMASK() is preferred to use for bitmasks.

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/thermal/imx8mm_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index c5cd873c6e01..74fc34b88bb0 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -23,8 +23,8 @@

#define TER_ADC_PD BIT(30)
#define TER_EN BIT(31)
-#define TRITSR_TEMP0_VAL_MASK 0xff
-#define TRITSR_TEMP1_VAL_MASK 0xff0000
+#define TRITSR_TEMP0_VAL_MASK GENMASK(7, 0)
+#define TRITSR_TEMP1_VAL_MASK GENMASK(23, 16)

#define PROBE_SEL_ALL GENMASK(31, 30)

--
2.37.1

2022-10-17 08:15:07

by Peng Fan (OSS)

Subject: Re: [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate

On 10/14/2022 4:16 PM, Marcus Folkesson wrote:
> GENMASK() is preferred to use for bitmasks.
>
> Signed-off-by: Marcus Folkesson <[email protected]>
> ---
> drivers/thermal/imx8mm_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index c5cd873c6e01..74fc34b88bb0 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -23,8 +23,8 @@
>
> #define TER_ADC_PD BIT(30)
> #define TER_EN BIT(31)
> -#define TRITSR_TEMP0_VAL_MASK 0xff
> -#define TRITSR_TEMP1_VAL_MASK 0xff0000
> +#define TRITSR_TEMP0_VAL_MASK GENMASK(7, 0)
> +#define TRITSR_TEMP1_VAL_MASK GENMASK(23, 16)
>
> #define PROBE_SEL_ALL GENMASK(31, 30)
>
Reviewed-by: Peng Fan <[email protected]>