2022-10-16 18:19:43

by Caleb Connolly

[permalink] [raw]
Subject: [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

This contains patches 6 through 10 of the series adding a driver
for the RRADC
https://lore.kernel.org/linux-arm-msm/[email protected]/

The driver and DT bindings have been in mainline for a while.

This introduces a new dtbs_check warning which is fixed in
https://lore.kernel.org/linux-arm-msm/[email protected]/
and depends on Luca's series:
https://lore.kernel.org/linux-arm-msm/[email protected]/

-Caleb

Caleb Connolly (4):
arm64: dts: qcom: pmi8998: add rradc node
arm64: dts: qcom: sdm845-oneplus: enable rradc
arm64: dts: qcom: sdm845-db845c: enable rradc
arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc

Jami Kettunen (1):
arm64: dts: qcom: msm8998-oneplus-common: enable RRADC

arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 8 ++++++++
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 ++++
5 files changed, 24 insertions(+)

--
2.38.0


2022-10-16 18:31:41

by Caleb Connolly

[permalink] [raw]
Subject: [PATCH 4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc

Enable the PMI8998 RRADC.

Signed-off-by: Caleb Connolly <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
index 82c27f90d300..6228c1899e3a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
@@ -336,6 +336,10 @@ resin {
};
};

+&pmi8998_rradc {
+ status = "okay";
+};
+
/* QUAT I2S Uses 1 I2S SD Line for audio on TAS2559/60 amplifiers */
&q6afedai {
qi2s@22 {
--
2.38.0

2022-11-07 03:36:14

by Caleb Connolly

[permalink] [raw]
Subject: Re: [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC



On 07/11/2022 03:11, Bjorn Andersson wrote:
> On Sun, 16 Oct 2022 19:03:24 +0100, Caleb Connolly wrote:
>> This contains patches 6 through 10 of the series adding a driver
>> for the RRADC
>> https://lore.kernel.org/linux-arm-msm/[email protected]/
>>
>> The driver and DT bindings have been in mainline for a while.
>>
>> This introduces a new dtbs_check warning which is fixed in
>> https://lore.kernel.org/linux-arm-msm/[email protected]/
>> and depends on Luca's series:
>> https://lore.kernel.org/linux-arm-msm/[email protected]/
>>
>> [...]
>
> Applied, thanks!

Hi Bjorn,

Apologies, I should have left a reply about re-spinning this; it's
been dropped to a single patch as Krzysztof suggested in [1] and is
currently pending a v4 (v3 can be found at [2]).

The changes aren't major, actually just enabling it by default rather
than per-device. If it would need to be reverted I could instead send
a followup to do this as well as add the missing dt bindings.

[1]:
https://lore.kernel.org/linux-arm-msm/[email protected]/
[2]:
https://lore.kernel.org/linux-arm-msm/[email protected]/

>
> [1/5] arm64: dts: qcom: pmi8998: add rradc node
> commit: 1cb78978d34e1b65bbb912d8265eb95713ae7a45
> [2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc
> commit: 868985181a69df53321035d96aa668d90f6cd5cb
> [3/5] arm64: dts: qcom: sdm845-db845c: enable rradc
> commit: e779eb99859cc26d051f6fc723d2bd2d5990a812
> [4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc
> commit: 53c54069d9ffd556b52893077324e628655cd591
> [5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC
> commit: aac16a9d247e5496361bfe20d651f2c1333eb5dc
>
> Best regards,

--
Kind Regards,
Caleb (they/them)

2022-11-07 04:00:49

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/5] arm64: dts: qcom: add and enable the pmi8998 RRADC

On Sun, 16 Oct 2022 19:03:24 +0100, Caleb Connolly wrote:
> This contains patches 6 through 10 of the series adding a driver
> for the RRADC
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> The driver and DT bindings have been in mainline for a while.
>
> This introduces a new dtbs_check warning which is fixed in
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> and depends on Luca's series:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> [...]

Applied, thanks!

[1/5] arm64: dts: qcom: pmi8998: add rradc node
commit: 1cb78978d34e1b65bbb912d8265eb95713ae7a45
[2/5] arm64: dts: qcom: sdm845-oneplus: enable rradc
commit: 868985181a69df53321035d96aa668d90f6cd5cb
[3/5] arm64: dts: qcom: sdm845-db845c: enable rradc
commit: e779eb99859cc26d051f6fc723d2bd2d5990a812
[4/5] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc
commit: 53c54069d9ffd556b52893077324e628655cd591
[5/5] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC
commit: aac16a9d247e5496361bfe20d651f2c1333eb5dc

Best regards,
--
Bjorn Andersson <[email protected]>