2022-10-17 09:36:24

by Jiapeng Chong

Subject: [PATCH] drm/rockchip: dsi: Remove the unused function dsi_update_bits()

The function dsi_update_bits() is defined in the dw-mipi-dsi-rockchip.c
file, but not called elsewhere, so delete this unused function.

drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:367:20: warning: unused function 'dsi_update_bits'.

https://bugzilla.openanolis.cn/show_bug.cgi?id=2414
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
index bf6948125b84..313231d886d2 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c
@@ -364,12 +364,6 @@ static inline u32 dsi_read(struct dw_mipi_dsi_rockchip *dsi, u32 reg)
return readl(dsi->base + reg);
}

-static inline void dsi_update_bits(struct dw_mipi_dsi_rockchip *dsi, u32 reg,
- u32 mask, u32 val)
-{
- dsi_write(dsi, reg, (dsi_read(dsi, reg) & ~mask) | val);
-}
-
static void dw_mipi_dsi_phy_write(struct dw_mipi_dsi_rockchip *dsi,
u8 test_code,
u8 test_data)
--
2.20.1.7.g153144c

2022-10-29 23:19:48

by Heiko Stuebner

Subject: Re: [PATCH] drm/rockchip: dsi: Remove the unused function dsi_update_bits()

On Mon, 17 Oct 2022 16:43:30 +0800, Jiapeng Chong wrote:
> The function dsi_update_bits() is defined in the dw-mipi-dsi-rockchip.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:367:20: warning: unused function 'dsi_update_bits'.
>
> https://bugzilla.openanolis.cn/show_bug.cgi?id=2414
>
> [...]

Applied, thanks!

[1/1] drm/rockchip: dsi: Remove the unused function dsi_update_bits()
commit: 3daf391fee830f2343cc6b1ba131b1b5115dea1f

Best regards,
--
Heiko Stuebner <[email protected]>