2022-10-17 10:07:49

by Jiapeng Chong

Subject: [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()

The function ip6gre_tnl_addr_conflict() is defined in the ip6_gre.c file,
but not called elsewhere, so delete this unused function.

net/ipv6/ip6_gre.c:887:20: warning: unused function 'ip6gre_tnl_addr_conflict'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2419
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/ipv6/ip6_gre.c | 20 --------------------
1 file changed, 20 deletions(-)

diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 48b4ff0294f6..02b1b54165e8 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -870,26 +870,6 @@ static inline int ip6gre_xmit_ipv6(struct sk_buff *skb, struct net_device *dev)
return 0;
}

-/**
- * ip6gre_tnl_addr_conflict - compare packet addresses to tunnel's own
- * @t: the outgoing tunnel device
- * @hdr: IPv6 header from the incoming packet
- *
- * Description:
- * Avoid trivial tunneling loop by checking that tunnel exit-point
- * doesn't match source of incoming packet.
- *
- * Return:
- * 1 if conflict,
- * 0 else
- **/
-
-static inline bool ip6gre_tnl_addr_conflict(const struct ip6_tnl *t,
- const struct ipv6hdr *hdr)
-{
- return ipv6_addr_equal(&t->parms.raddr, &hdr->saddr);
-}
-
static int ip6gre_xmit_other(struct sk_buff *skb, struct net_device *dev)
{
struct ip6_tnl *t = netdev_priv(dev);
--
2.20.1.7.g153144c

2022-10-18 10:19:45

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <[email protected]>:

On Mon, 17 Oct 2022 17:35:40 +0800 you wrote:
> The function ip6gre_tnl_addr_conflict() is defined in the ip6_gre.c file,
> but not called elsewhere, so delete this unused function.
>
> net/ipv6/ip6_gre.c:887:20: warning: unused function 'ip6gre_tnl_addr_conflict'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2419
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()
https://git.kernel.org/netdev/net-next/c/f00909e2e6fe

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html