2022-10-17 17:15:51

by Dario Binacchi

Subject: [PATCH] clk: ti: mux: don't free `parent_names' on kzalloc() failure

Although no operation is performed by kfree() on a NULL pointer, it's
however suboptimal and semantically wrong doing it.

Signed-off-by: Dario Binacchi <[email protected]>

---

drivers/clk/ti/mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/mux.c b/drivers/clk/ti/mux.c
index 46b45b3e8319..1f924db2ad98 100644
--- a/drivers/clk/ti/mux.c
+++ b/drivers/clk/ti/mux.c
@@ -182,7 +182,7 @@ static void of_mux_clk_setup(struct device_node *node)
}
parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
if (!parent_names)
- goto cleanup;
+ return;

of_clk_parent_fill(node, parent_names, num_parents);

--
2.32.0

2022-10-28 00:54:18

by Stephen Boyd

Subject: Re: [PATCH] clk: ti: mux: don't free `parent_names' on kzalloc() failure

Quoting Dario Binacchi (2022-10-17 09:46:46)
> Although no operation is performed by kfree() on a NULL pointer, it's
> however suboptimal and semantically wrong doing it.

Passing NULL to kfree() is fine. This is trying to optimize an error
path as well. No thanks.