2022-10-17 19:10:38

by Caleb Connolly

Subject: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node

Document the rradc node name, like adc-tm it's only used on a few
platforms, so differentiate it from the standard adc node.

Signed-off-by: Caleb Connolly <[email protected]>
---

V1: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
* Add a new node instead of using the adc@ node
* no longer depend on Luca's patch
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545..631141f99bce 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -101,6 +101,10 @@ patternProperties:
type: object
$ref: /schemas/thermal/qcom-spmi-adc-tm5.yaml#

+ "^rradc@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml#
+
"^audio-codec@[0-9a-f]+$":
type: object
additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
--
2.38.0

2022-10-17 20:00:15

by Rob Herring

Subject: Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node

On Mon, Oct 17, 2022 at 1:52 PM Caleb Connolly
<[email protected]> wrote:
>
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
>
> V1: https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v1:
> * Add a new node instead of using the adc@ node
> * no longer depend on Luca's patch
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> 1 file changed, 4 insertions(+)

Doesn't apply to rc1.

Rob

2022-10-17 20:27:17

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: document rradc node

On 17/10/2022 14:51, Caleb Connolly wrote:
> Document the rradc node name, like adc-tm it's only used on a few
> platforms, so differentiate it from the standard adc node.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
>
> V1: https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v1:
> * Add a new node instead of using the adc@ node
> * no longer depend on Luca's patch

This is not what I proposed. The node name should stay adc as it is
generic. I propose to do it the same way as in
f4b632da13cf0ee39cdbd4ff08d1961ed50e3c14

Best regards,
Krzysztof