2022-09-13 03:40:21

by Yang Yingliang

Subject: [PATCH -next] clk: bulk: Use dev_err_probe() helper in __clk_bulk_get()

dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/clk/clk-bulk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
index e9e16425c739..826b3ff99433 100644
--- a/drivers/clk/clk-bulk.c
+++ b/drivers/clk/clk-bulk.c
@@ -96,9 +96,9 @@ static int __clk_bulk_get(struct device *dev, int num_clks,
if (ret == -ENOENT && optional)
continue;

- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Failed to get clk '%s': %d\n",
- clks[i].id, ret);
+ dev_err_probe(dev, ret,
+ "Failed to get clk '%s'\n",
+ clks[i].id);
goto err;
}
}
--
2.25.1

2022-10-17 23:44:34

by Stephen Boyd

Subject: Re: [PATCH -next] clk: bulk: Use dev_err_probe() helper in __clk_bulk_get()

Quoting Yang Yingliang (2022-09-12 20:24:03)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---

Applied to clk-next