The orangefs* function has been optimized as follows.
1. Remove the initialization assignment of variables, which are assigned
first.
2. Remove void* associated variable cast.
Signed-off-by: Li zeming <[email protected]>
---
fs/orangefs/inode.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
index 7a8c0c6e698d..54d47b9ad0db 100644
--- a/fs/orangefs/inode.c
+++ b/fs/orangefs/inode.c
@@ -719,7 +719,7 @@ static int orangefs_setattr_size(struct inode *inode, struct iattr *iattr)
struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
struct orangefs_kernel_op_s *new_op;
loff_t orig_size;
- int ret = -EINVAL;
+ int ret;
gossip_debug(GOSSIP_INODE_DEBUG,
"%s: %pU: Handle is %pU | fs_id %d | size is %llu\n",
@@ -941,7 +941,7 @@ static int orangefs_fileattr_get(struct dentry *dentry, struct fileattr *fa)
static int orangefs_fileattr_set(struct user_namespace *mnt_userns,
struct dentry *dentry, struct fileattr *fa)
{
- u64 val = 0;
+ u64 val;
gossip_debug(GOSSIP_FILE_DEBUG, "%s: called on %pd\n", __func__,
dentry);
@@ -1021,7 +1021,7 @@ static inline ino_t orangefs_handle_hash(struct orangefs_object_kref *ref)
*/
static int orangefs_set_inode(struct inode *inode, void *data)
{
- struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
+ struct orangefs_object_kref *ref = data;
ORANGEFS_I(inode)->refn.fs_id = ref->fs_id;
ORANGEFS_I(inode)->refn.khandle = ref->khandle;
ORANGEFS_I(inode)->attr_valid = 0;
@@ -1036,8 +1036,8 @@ static int orangefs_set_inode(struct inode *inode, void *data)
*/
static int orangefs_test_inode(struct inode *inode, void *data)
{
- struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
- struct orangefs_inode_s *orangefs_inode = NULL;
+ struct orangefs_object_kref *ref = data;
+ struct orangefs_inode_s *orangefs_inode;
orangefs_inode = ORANGEFS_I(inode);
/* test handles and fs_ids... */
@@ -1056,7 +1056,7 @@ static int orangefs_test_inode(struct inode *inode, void *data)
struct inode *orangefs_iget(struct super_block *sb,
struct orangefs_object_kref *ref)
{
- struct inode *inode = NULL;
+ struct inode *inode;
unsigned long hash;
int error;
--
2.18.2