2022-10-18 08:20:03

by Jiapeng Chong

Subject: [PATCH] target: Remove the unused function transport_lba_64_ext()

The function transport_lba_64_ext() is defined in the target_core_sbc.c
file, but not called elsewhere, so remove this unused function.

drivers/target/target_core_sbc.c:276:34: warning: unused function 'transport_lba_64_ext'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2427
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/target/target_core_sbc.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index 1e3216de1e04..1cd41e3834bb 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -270,14 +270,6 @@ static inline unsigned long long transport_lba_64(unsigned char *cdb)
return get_unaligned_be64(&cdb[2]);
}

-/*
- * For VARIABLE_LENGTH_CDB w/ 32 byte extended CDBs
- */
-static inline unsigned long long transport_lba_64_ext(unsigned char *cdb)
-{
- return get_unaligned_be64(&cdb[12]);
-}
-
static sense_reason_t
sbc_setup_write_same(struct se_cmd *cmd, unsigned char flags, struct sbc_ops *ops)
{
--
2.20.1.7.g153144c

2022-10-27 03:18:02

by Martin K. Petersen

Subject: Re: [PATCH] target: Remove the unused function transport_lba_64_ext()

On Tue, 18 Oct 2022 16:12:35 +0800, Jiapeng Chong wrote:

> The function transport_lba_64_ext() is defined in the target_core_sbc.c
> file, but not called elsewhere, so remove this unused function.
>
> drivers/target/target_core_sbc.c:276:34: warning: unused function 'transport_lba_64_ext'.
>
>

Applied to 6.2/scsi-queue, thanks!

[1/1] target: Remove the unused function transport_lba_64_ext()
https://git.kernel.org/mkp/scsi/c/621a323c3a7e

--
Martin K. Petersen Oracle Linux Engineering