2022-10-18 10:26:01

by Ryosuke Yasuoka

Subject: [PATCH] kcsan: Fix trivial typo in Kconfig help comments

Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
KCSAN_SKIP_WATCH_RANDOMIZE

Signed-off-by: Ryosuke Yasuoka <[email protected]>
---
lib/Kconfig.kcsan | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
index 47a693c45864..375575a5a0e3 100644
--- a/lib/Kconfig.kcsan
+++ b/lib/Kconfig.kcsan
@@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
default 4000
help
The number of per-CPU memory operations to skip, before another
- watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
+ watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
memory operations are used to set up a watchpoint. A smaller value
results in more aggressive race detection, whereas a larger value
improves system performance at the cost of missing some races.
@@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
default y
help
If instruction skip count should be randomized, where the maximum is
- KCSAN_WATCH_SKIP. If false, the chosen value is always
- KCSAN_WATCH_SKIP.
+ KCSAN_SKIP_WATCH. If false, the chosen value is always
+ KCSAN_SKIP_WATCH.

config KCSAN_INTERRUPT_WATCHER
bool "Interruptible watchers" if !KCSAN_STRICT
--
2.37.3

2022-10-18 15:21:33

by Marco Elver

Subject: Re: [PATCH] kcsan: Fix trivial typo in Kconfig help comments

On Tue, 18 Oct 2022 at 03:23, Ryosuke Yasuoka <[email protected]> wrote:
>
> Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
> KCSAN_SKIP_WATCH_RANDOMIZE
>
> Signed-off-by: Ryosuke Yasuoka <[email protected]>

Reviewed-by: Marco Elver <[email protected]>

Thanks.

> ---
> lib/Kconfig.kcsan | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
> index 47a693c45864..375575a5a0e3 100644
> --- a/lib/Kconfig.kcsan
> +++ b/lib/Kconfig.kcsan
> @@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
> default 4000
> help
> The number of per-CPU memory operations to skip, before another
> - watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
> + watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
> memory operations are used to set up a watchpoint. A smaller value
> results in more aggressive race detection, whereas a larger value
> improves system performance at the cost of missing some races.
> @@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
> default y
> help
> If instruction skip count should be randomized, where the maximum is
> - KCSAN_WATCH_SKIP. If false, the chosen value is always
> - KCSAN_WATCH_SKIP.
> + KCSAN_SKIP_WATCH. If false, the chosen value is always
> + KCSAN_SKIP_WATCH.
>
> config KCSAN_INTERRUPT_WATCHER
> bool "Interruptible watchers" if !KCSAN_STRICT
> --
> 2.37.3
>

2022-10-18 18:03:04

by Paul E. McKenney

Subject: Re: [PATCH] kcsan: Fix trivial typo in Kconfig help comments

On Tue, Oct 18, 2022 at 08:15:26AM -0700, Marco Elver wrote:
> On Tue, 18 Oct 2022 at 03:23, Ryosuke Yasuoka <[email protected]> wrote:
> >
> > Fix trivial typo in Kconfig help comments in KCSAN_SKIP_WATCH and
> > KCSAN_SKIP_WATCH_RANDOMIZE
> >
> > Signed-off-by: Ryosuke Yasuoka <[email protected]>
>
> Reviewed-by: Marco Elver <[email protected]>

Applied, thank you both!

Thanx, Paul

> Thanks.
>
> > ---
> > lib/Kconfig.kcsan | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
> > index 47a693c45864..375575a5a0e3 100644
> > --- a/lib/Kconfig.kcsan
> > +++ b/lib/Kconfig.kcsan
> > @@ -125,7 +125,7 @@ config KCSAN_SKIP_WATCH
> > default 4000
> > help
> > The number of per-CPU memory operations to skip, before another
> > - watchpoint is set up, i.e. one in KCSAN_WATCH_SKIP per-CPU
> > + watchpoint is set up, i.e. one in KCSAN_SKIP_WATCH per-CPU
> > memory operations are used to set up a watchpoint. A smaller value
> > results in more aggressive race detection, whereas a larger value
> > improves system performance at the cost of missing some races.
> > @@ -135,8 +135,8 @@ config KCSAN_SKIP_WATCH_RANDOMIZE
> > default y
> > help
> > If instruction skip count should be randomized, where the maximum is
> > - KCSAN_WATCH_SKIP. If false, the chosen value is always
> > - KCSAN_WATCH_SKIP.
> > + KCSAN_SKIP_WATCH. If false, the chosen value is always
> > + KCSAN_SKIP_WATCH.
> >
> > config KCSAN_INTERRUPT_WATCHER
> > bool "Interruptible watchers" if !KCSAN_STRICT
> > --
> > 2.37.3
> >