2022-10-19 11:58:15

by Xianting Tian

Subject: [PATCH V4 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

The following interrelated definitions and ranges are needed by the kdump
crash tool, which are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
KERNEL_LINK_ADDR,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,

Document these RISCV64 exports above.

Signed-off-by: Xianting Tian <[email protected]>
---
.../admin-guide/kdump/vmcoreinfo.rst | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
index 6726f439958c..86fd88492870 100644
--- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
+++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
@@ -595,3 +595,32 @@ X2TLB
-----

Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of the direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KERNEL_LINK_ADDR
+----------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+ * MODULES_VADDR ~ MODULES_END : Kernel module space.
+ * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+ * VMEMMAP_START ~ VMEMMAP_END : vmemmap space, used for struct page array.
+ * KERNEL_LINK_ADDR : start address of Kernel link and BPF
--
2.17.1

2022-10-20 03:04:14

by Bagas Sanjaya

Subject: Re: [PATCH V4 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

On 10/19/22 17:36, Xianting Tian wrote:
> The following interrelated definitions and ranges are needed by the kdump
> crash tool, which are exported by "arch/riscv/kernel/crash_core.c":
> VA_BITS,
> PAGE_OFFSET,
> phys_ram_base,
> KERNEL_LINK_ADDR,
> MODULES_VADDR ~ MODULES_END,
> VMALLOC_START ~ VMALLOC_END,
> VMEMMAP_START ~ VMEMMAP_END,
>
> Document these RISCV64 exports above.
>
> Signed-off-by: Xianting Tian <[email protected]>

Hi Xianting,

Seems like you forgot to keep carrying my Reviewed-by from v3 [1].
Anyway, here it goes...

Reviewed-by: Bagas Sanjaya <[email protected]>

Thanks.

[1]: https://lore.kernel.org/linux-doc/[email protected]/

--
An old man doll... just what I always wanted! - Clara

2022-10-20 03:04:21

by Xianting Tian

Subject: Re: [PATCH V4 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

在 2022/10/20 上午9:56, Bagas Sanjaya 写道:
> On 10/19/22 17:36, Xianting Tian wrote:
>> The following interrelated definitions and ranges are needed by the kdump
>> crash tool, which are exported by "arch/riscv/kernel/crash_core.c":
>> VA_BITS,
>> PAGE_OFFSET,
>> phys_ram_base,
>> KERNEL_LINK_ADDR,
>> MODULES_VADDR ~ MODULES_END,
>> VMALLOC_START ~ VMALLOC_END,
>> VMEMMAP_START ~ VMEMMAP_END,
>>
>> Document these RISCV64 exports above.
>>
>> Signed-off-by: Xianting Tian <[email protected]>
> Hi Xianting,
>
> Seems like you forgot to keep carrying my Reviewed-by from v3 [1].
> Anyway, here it goes...
>
> Reviewed-by: Bagas Sanjaya <[email protected]>
Sorry, I forgot... :(
>
> Thanks.
>
> [1]: https://lore.kernel.org/linux-doc/[email protected]/
>