2022-10-19 15:55:04

by John Ogness

Subject: [PATCH printk v2 11/38] tty: serial: earlycon: use console_is_enabled()

Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <[email protected]>
---
drivers/tty/serial/earlycon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
index a5f380584cda..bdfb60da97bd 100644
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -181,7 +181,7 @@ int __init setup_earlycon(char *buf)
if (!buf || !buf[0])
return -EINVAL;

- if (early_con.flags & CON_ENABLED)
+ if (console_is_enabled(&early_con))
return -EALREADY;

again:
@@ -253,7 +253,7 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
bool big_endian;
u64 addr;

- if (early_con.flags & CON_ENABLED)
+ if (console_is_enabled(&early_con))
return -EALREADY;

spin_lock_init(&port->lock);
--
2.30.2

2022-10-19 16:13:33

by Greg Kroah-Hartman

Subject: Re: [PATCH printk v2 11/38] tty: serial: earlycon: use console_is_enabled()

On Wed, Oct 19, 2022 at 05:01:33PM +0206, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2022-10-21 14:27:48

by Petr Mladek

Subject: Re: [PATCH printk v2 11/38] tty: serial: earlycon: use console_is_enabled()

On Wed 2022-10-19 17:01:33, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr