2022-10-19 15:09:37

by John Ogness

[permalink] [raw]
Subject: [PATCH printk v2 17/38] tty: tty_io: use console_is_enabled()

Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <[email protected]>
---
drivers/tty/tty_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index de06c3c2ff70..2050e63963bb 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -3532,7 +3532,7 @@ static ssize_t show_cons_active(struct device *dev,
continue;
if (!c->write)
continue;
- if ((c->flags & CON_ENABLED) == 0)
+ if (!console_is_enabled(c))
continue;
cs[i++] = c;
if (i >= ARRAY_SIZE(cs))
--
2.30.2


2022-10-19 16:09:50

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH printk v2 17/38] tty: tty_io: use console_is_enabled()

On Wed, Oct 19, 2022 at 05:01:39PM +0206, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>
> ---
> drivers/tty/tty_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2022-10-21 14:52:26

by Petr Mladek

[permalink] [raw]
Subject: Re: [PATCH printk v2 17/38] tty: tty_io: use console_is_enabled()

On Wed 2022-10-19 17:01:39, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr