2022-10-19 15:09:22

by John Ogness

Subject: [PATCH printk v2 18/38] usb: early: xhci-dbc: use console_is_enabled()

Replace (console->flags & CON_ENABLED) usage with console_is_enabled().

Signed-off-by: John Ogness <[email protected]>
---
drivers/usb/early/xhci-dbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index bfb7e2b85299..b1a9c393160b 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -927,7 +927,7 @@ void __init early_xdbc_register_console(void)

static void xdbc_unregister_console(void)
{
- if (early_xdbc_console.flags & CON_ENABLED)
+ if (console_is_enabled(&early_xdbc_console))
unregister_console(&early_xdbc_console);
}

--
2.30.2

2022-10-19 16:48:07

by Greg Kroah-Hartman

Subject: Re: [PATCH printk v2 18/38] usb: early: xhci-dbc: use console_is_enabled()

On Wed, Oct 19, 2022 at 05:01:40PM +0206, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2022-10-21 14:51:30

by Petr Mladek

Subject: Re: [PATCH printk v2 18/38] usb: early: xhci-dbc: use console_is_enabled()

On Wed 2022-10-19 17:01:40, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <[email protected]>
> ---
> drivers/usb/early/xhci-dbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
> index bfb7e2b85299..b1a9c393160b 100644
> --- a/drivers/usb/early/xhci-dbc.c
> +++ b/drivers/usb/early/xhci-dbc.c
> @@ -927,7 +927,7 @@ void __init early_xdbc_register_console(void)
>
> static void xdbc_unregister_console(void)
> {
> - if (early_xdbc_console.flags & CON_ENABLED)
> + if (console_is_enabled(&early_xdbc_console))
> unregister_console(&early_xdbc_console);
> }

Again, we should rather check here if the console is in console_list.

But it is old bug. It might be fixed later. The patch does not change
the existing behavior. Feel free to use:

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr