2022-10-21 08:33:20

by Thomas Richter

[permalink] [raw]
Subject: [PATCH] perf list: Fix PMU name pai_crypto in perf list on s390

commit e0b23af82d6f4 ("perf list: Add PMU pai_crypto event description for IBM z16")
introduced the Processor Activity Instrumentation for cryptographic
counters for z16. The PMU device driver exports the counters via sysfs
files listed in directory /sys/devices/pai_crypto.

To specify an event from that PMU, use perf stat -e pai_crypto/XXX/

However the json file mentioned in above commit exports the counter
decriptions in file pmu-events/arch/s390/cf_z16/pai.json.
Rename this file to pmu-events/arch/s390/cf_z16/pai_crypto.json
to make the naming consistent.

Now perf list shows the counter names under pai_crypto section:
pai_crypto:
CRYPTO_ALL
[CRYPTO ALL. Unit: pai_crypto]
....

Output before was
pai:
CRYPTO_ALL
[CRYPTO ALL. Unit: pai_crypto]
....

Fixes: e0b23af82d6f4 ("perf list: Add PMU pai_crypto event description for IBM z16")
Signed-off-by: Thomas Richter <[email protected]>
Acked-by: Sumanth Korikkar <[email protected]>
---
.../pmu-events/arch/s390/cf_z16/{pai.json => pai_crypto.json} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tools/perf/pmu-events/arch/s390/cf_z16/{pai.json => pai_crypto.json} (100%)

diff --git a/tools/perf/pmu-events/arch/s390/cf_z16/pai.json b/tools/perf/pmu-events/arch/s390/cf_z16/pai_crypto.json
similarity index 100%
rename from tools/perf/pmu-events/arch/s390/cf_z16/pai.json
rename to tools/perf/pmu-events/arch/s390/cf_z16/pai_crypto.json
--
2.37.3


2022-10-24 12:07:42

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH] perf list: Fix PMU name pai_crypto in perf list on s390

Em Fri, Oct 21, 2022 at 10:25:57AM +0200, Thomas Richter escreveu:
> commit e0b23af82d6f4 ("perf list: Add PMU pai_crypto event description for IBM z16")
> introduced the Processor Activity Instrumentation for cryptographic
> counters for z16. The PMU device driver exports the counters via sysfs
> files listed in directory /sys/devices/pai_crypto.

Thanks, applied.

- Arnaldo