2022-10-23 21:48:51

by Nam Cao

[permalink] [raw]
Subject: [PATCH] coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE

The function dump_emit_page() is only called in dump_user_range(), which
is wrapped in #ifdef CONFIG_ELF_CORE. This causes a build error when
CONFIG_ELF_CORE is disabled:

CC fs/coredump.o
fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
834 | static int dump_emit_page(struct coredump_params *cprm, struct page *page)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE to avoid build problem.

Signed-off-by: Nam Cao <[email protected]>
---
fs/coredump.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index 7bad7785e8e6..8663042ebe9c 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
}
}

+#ifdef CONFIG_ELF_CORE
static int dump_emit_page(struct coredump_params *cprm, struct page *page)
{
struct bio_vec bvec = {
@@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)

return 1;
}
+#endif

int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
{
--
2.25.1